This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2622

ui: adding a generic method to read config items with an arbitrary type
Needs RevisionPublic

Authored by rdamazio on Mar 3 2018, 6:54 PM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers
Summary

This can be used for reading many config options of various types where the
type of each is known in some other structure (e.g. options matching command
flags).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

rdamazio created this revision.Mar 3 2018, 6:54 PM
baymax requested changes to this revision.Jan 24 2020, 12:33 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:33 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (10 lines)

Diff 6520

mercurial/ui.py

for k, v in sub.items(): for k, v in sub.items():
uvalue = self._ucfg.get(section, '%s:%s' % (name, k)) uvalue = self._ucfg.get(section, '%s:%s' % (name, k))
if uvalue is not None and uvalue != v: if uvalue is not None and uvalue != v:
self.debug('ignoring untrusted configuration option ' self.debug('ignoring untrusted configuration option '
'%s:%s.%s = %s\n' % (section, name, k, uvalue)) '%s:%s.%s = %s\n' % (section, name, k, uvalue))
return main, sub return main, sub
def configtyped(self, section, name, itemtype, default=_unset, untrusted=False):
"""Get a config item as the given type."""
if itemtype is type(False) or itemtype is type(None):
return self.configbool(section, name, default, untrusted)
if itemtype is type(1):
return self.configint(section, name, default, untrusted)
if itemtype is type([]):
return self.configlist(section, name, default, untrusted)
return self.config(section, name, default, untrusted)
def configpath(self, section, name, default=_unset, untrusted=False): def configpath(self, section, name, default=_unset, untrusted=False):
'get a path config item, expanded relative to repo root or config file' 'get a path config item, expanded relative to repo root or config file'
v = self.config(section, name, default, untrusted) v = self.config(section, name, default, untrusted)
if v is None: if v is None:
return None return None
if not os.path.isabs(v) or "://" not in v: if not os.path.isabs(v) or "://" not in v:
src = self.configsource(section, name, untrusted) src = self.configsource(section, name, untrusted)
if ':' in src: if ':' in src: