Provide interactive preview. undo -p now provides support of using arrow keys
and return to select state. The interactive ui is set up to be generic so
potentially could be used for other commands.
Details
- Reviewers
stash quark - Group Reviewers
Restricted Project - Commits
- rFBHGXfc85e73e3882: undo: preview interactive ui
- Running a bash script that sets up an interesting repo
- hitting hg undo -p and trying every key combination Specifically: control-C still works, q quits, left goes forward, right goes backwards, return brings you to a state
- running redo after preview and return
- running undo a few times and then using undo -p to go back forward
- going out of bounds both up and down
- hitting other random keys during hg undo -p
- running hg undo -p with other flags
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Current test plan involves doing the following:
- Running a bash script that sets up an interesting repo
- hitting hg undo -p and trying every key combination Specifically: control-C still works, q quits, left goes forward, right goes backwards, return brings you to a state
- running redo after preview and return
- running undo a few times and then using undo -p to go back forward
- going out of bounds both up and down
- hitting other random keys during hg undo -p
- running hg undo -p with other flags. Note that --branch doesn't give you the correct preview
hgext3rd/interactiveui.py | ||
---|---|---|
23–24 | I honestly don't know much about licensing. The code seems to be licensed under BSD. |
Will review later. Test Plan could be moved to commit message by having a "Test Plan:" section header.
hgext3rd/interactiveui.py | ||
---|---|---|
23–24 | I would copy the entire https://github.com/pallets/click/blob/master/LICENSE file here as a block comment (as requested by the license - "Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.", plus a short comment saying that we made some changes to it). |
Maybe move the license to before getchar, since the name getchar is also from there.
hgext3rd/interactiveui.py | ||
---|---|---|
8 | Better to add from __future__ import absolute_import here. |
Better to add
here.