This is an archive of the discontinued Mercurial Phabricator instance.

archival: fsdecode paths before passing to tar or zip objects
ClosedPublic

Authored by durin42 on Mar 4 2018, 1:11 PM.

Details

Summary

Both of these traffic in unicodes for filenames on Python 3, and
inspection of the tarfile module shows that it uses the filesystem
encoding, so fsdecode is the right choice.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Mar 4 2018, 1:11 PM
pulkit accepted this revision.Mar 4 2018, 1:19 PM
indygreg accepted this revision.Mar 4 2018, 1:26 PM
This revision is now accepted and ready to land.Mar 4 2018, 1:26 PM
This revision was automatically updated to reflect the committed changes.