( )⚙ D2665 py3: use bytes() instead of str()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2665

py3: use bytes() instead of str()
ClosedPublic

Authored by pulkit on Mar 4 2018, 2:40 PM.

Details

Reviewers
indygreg
yuja
Group Reviewers
hg-reviewers
Commits
rHG6bacb2f663cb: py3: use bytes() instead of str()
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Mar 4 2018, 2:40 PM
pulkit updated this revision to Diff 6602.Mar 4 2018, 2:47 PM
yuja accepted this revision.Mar 4 2018, 3:16 PM
This revision is now accepted and ready to land.Mar 4 2018, 3:16 PM
Closed by commit rHG6bacb2f663cb: py3: use bytes() instead of str() (authored by pulkit). · Explain WhyMar 4 2018, 3:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (2 lines)

Diff 6606

mercurial/revlog.py

# (Possibly) reuse the delta from the revlog if allowed and # (Possibly) reuse the delta from the revlog if allowed and
# the revlog chunk is a delta. # the revlog chunk is a delta.
cachedelta = None cachedelta = None
rawtext = None rawtext = None
if populatecachedelta: if populatecachedelta:
dp = self.deltaparent(rev) dp = self.deltaparent(rev)
if dp != nullrev: if dp != nullrev:
cachedelta = (dp, str(self._chunk(rev))) cachedelta = (dp, bytes(self._chunk(rev)))
if not cachedelta: if not cachedelta:
rawtext = self.revision(rev, raw=True) rawtext = self.revision(rev, raw=True)
if deltareuse == self.DELTAREUSEFULLADD: if deltareuse == self.DELTAREUSEFULLADD:
destrevlog.addrevision(rawtext, tr, linkrev, p1, p2, destrevlog.addrevision(rawtext, tr, linkrev, p1, p2,
cachedelta=cachedelta, cachedelta=cachedelta,