This is an archive of the discontinued Mercurial Phabricator instance.

tests: stop over-specifying tempfile name
ClosedPublic

Authored by durin42 on Mar 4 2018, 4:50 PM.

Details

Summary

Python 3 has more random characters in the default template, which is fine.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Mar 4 2018, 4:50 PM
durin42 updated this revision to Diff 6633.Mar 4 2018, 5:18 PM

I'm -0 on this. I'd prefer to change the temp file code to be consistent between Python versions. Preferably standardizing on the Python 3 version.

I'm -0 on this. I'd prefer to change the temp file code to be consistent between Python versions. Preferably standardizing on the Python 3 version.

It looks like these are coming from filemerge._maketempfiles, which is using tempfile.mkstemp(). I don't see a way to influence the number of wildcard characters there.

durin42 updated this revision to Diff 6732.Mar 8 2018, 2:26 PM
durin42 updated this revision to Diff 7096.Mar 17 2018, 10:00 PM

Friendly ping.

yuja accepted this revision.Mar 19 2018, 9:32 AM
This revision is now accepted and ready to land.Mar 19 2018, 9:32 AM
This revision was automatically updated to reflect the committed changes.