This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2697

util: stop calling os.stat_float_times()
ClosedPublic

Authored by durin42 on Mar 5 2018, 4:08 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG86ba6e3eba4e: util: stop calling os.stat_float_times()
Summary

It had Python-wide side effects, and it disappears in 3.7.0.

As of this change, we're mostly working on 3.7.0b2. There are a few
worrying failures, mostly around regular expressions, but we'll have
to tackle those separately.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Mar 5 2018, 4:08 PM
yuja accepted this revision.Mar 8 2018, 7:57 AM
This revision is now accepted and ready to land.Mar 8 2018, 7:57 AM
Closed by commit rHG86ba6e3eba4e: util: stop calling os.stat_float_times() (authored by durin42). · Explain WhyMar 8 2018, 8:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (5 lines)

Diff 6657

mercurial/util.py

unblocksignal = osutil.unblocksignal unblocksignal = osutil.unblocksignal
except AttributeError: except AttributeError:
pass pass
# Python compatibility # Python compatibility
_notset = object() _notset = object()
# disable Python's problematic floating point timestamps (issue4836)
# (Python hypocritically says you shouldn't change this behavior in
# libraries, and sure enough Mercurial is not a library.)
os.stat_float_times(False)
def safehasattr(thing, attr): def safehasattr(thing, attr):
return getattr(thing, attr, _notset) is not _notset return getattr(thing, attr, _notset) is not _notset
def _rapply(f, xs): def _rapply(f, xs):
if xs is None: if xs is None:
# assume None means non-value of optional data # assume None means non-value of optional data
return xs return xs
if isinstance(xs, (list, set, tuple)): if isinstance(xs, (list, set, tuple)):