This is an archive of the discontinued Mercurial Phabricator instance.

osutil: implement minimal __getitem__ compatibility on our custom listdir type
ClosedPublic

Authored by durin42 on Mar 5 2018, 4:08 PM.

Details

Summary

We previously declined to do this, but the removal of the deprecated
os.stat_float_times() method in Python 3.7 forces our hand.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Mar 5 2018, 4:08 PM
indygreg requested changes to this revision.Mar 5 2018, 7:02 PM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
mercurial/cext/osutil.c
130

I think this should be PyExc_IndexError.

This revision now requires changes to proceed.Mar 5 2018, 7:02 PM
mharbison72 added inline comments.
mercurial/cext/osutil.c
130

s/suport/support/

durin42 marked 2 inline comments as done.Mar 6 2018, 1:57 PM
durin42 updated this revision to Diff 6675.Mar 6 2018, 1:58 PM
durin42 updated this revision to Diff 6678.Mar 6 2018, 2:02 PM
yuja accepted this revision.Mar 8 2018, 7:57 AM
This revision was automatically updated to reflect the committed changes.