I think you should send the relative import patches to upstream. Adding from __future__ import absolute_import would also be a nice touch.

In D2752#44289, @indygreg wrote:

I think you should send the relative import patches to upstream. Adding from __future__ import absolute_import would also be a nice touch.

I tried that at https://github.com/agronholm/cbor2/pull/20. I might be doing something wrong here but I am not sure what's that.

In D2752#45926, @pulkit wrote:

In D2752#44289, @indygreg wrote:

I think you should send the relative import patches to upstream. Adding from __future__ import absolute_import would also be a nice touch.

I tried that at https://github.com/agronholm/cbor2/pull/20. I might be doing something wrong here but I am not sure what's that.

I started engaging the package author on that PR. I care enough about this issue that I may start a discussion on a Python mailing list about it. Not sure which one though.

@alex_gaynor: if I wanted to convince some heavy hitters in the Python community that relative imports within packages should be a best practice, how would you recommend going about that?

In D2752#47299, @indygreg wrote:

@alex_gaynor: if I wanted to convince some heavy hitters in the Python community that relative imports within packages should be a best practice, how would you recommend going about that?

The heaviest stick would be to write a PEP encouraging this practice, that way there'd be a canonical place to point people.

An intermediate step might be starting a thread on python-dev (or maybe python-ideas) about it.

You can also always blog about why it's useful. I think best practices around relative imports (explicit and implicit) were formed in a different era and deserve reconsideration.

In D2752#47301, @alex_gaynor wrote:

In D2752#47299, @indygreg wrote:

An intermediate step might be starting a thread on python-dev (or maybe python-ideas) about it.

https://mail.python.org/pipermail/python-dev/2018-March/152446.html

In D2752#45926, @pulkit wrote:

In D2752#44289, @indygreg wrote:

I think you should send the relative import patches to upstream. Adding from __future__ import absolute_import would also be a nice touch.

I tried that at https://github.com/agronholm/cbor2/pull/20. I might be doing something wrong here but I am not sure what's that.

The relative imports are now done: https://github.com/agronholm/cbor2/commit/84181540f6eb650437e3f73cd104a65661fe8e67

I also fixed this in flight to make the import in __init__.py relative.