This is an archive of the discontinued Mercurial Phabricator instance.

Differential D276

i18n: fix check-translation.py to be less broken on Python 3
ClosedPublic

Authored by durin42 on Aug 8 2017, 3:49 PM.

Details

Reviewers
quark
Group Reviewers
hg-reviewers
Commits
rHG29238dbf718e: i18n: fix check-translation.py to be less broken on Python 3
Summary

These are all simple one-argument print statements, so this syntax
works the same way in 2 and 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Aug 8 2017, 3:49 PM
quark accepted this revision.Aug 9 2017, 1:15 AM
Closed by commit rHG29238dbf718e: i18n: fix check-translation.py to be less broken on Python 3 (authored by durin42). · Explain WhyAug 9 2017, 10:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mi18n/check-translation.py (16 lines)

Diff 671

i18n/check-translation.py

def promptchoice(pe): def promptchoice(pe):
"""Check translation of the string given to "ui.promptchoice()" """Check translation of the string given to "ui.promptchoice()"
>>> pe = polib.POEntry( >>> pe = polib.POEntry(
... msgid ='prompt$$missing &sep$$missing &amp$$followed by &none', ... msgid ='prompt$$missing &sep$$missing &amp$$followed by &none',
... msgstr='prompt missing &sep$$missing amp$$followed by none&') ... msgstr='prompt missing &sep$$missing amp$$followed by none&')
>>> match(promptchoice, pe) >>> match(promptchoice, pe)
True True
>>> for e in promptchoice(pe): print e >>> for e in promptchoice(pe): print(e)
number of choices differs between msgid and msgstr number of choices differs between msgid and msgstr
msgstr has invalid choice missing '&' msgstr has invalid choice missing '&'
msgstr has invalid '&' followed by none msgstr has invalid '&' followed by none
""" """
idchoices = [c.rstrip(' ') for c in pe.msgid.split('$$')[1:]] idchoices = [c.rstrip(' ') for c in pe.msgid.split('$$')[1:]]
strchoices = [c.rstrip(' ') for c in pe.msgstr.split('$$')[1:]] strchoices = [c.rstrip(' ') for c in pe.msgstr.split('$$')[1:]]
if len(idchoices) != len(strchoices): if len(idchoices) != len(strchoices):
... msgid = '(DEPRECATED)', ... msgid = '(DEPRECATED)',
... msgstr= '(DETACERPED)') ... msgstr= '(DETACERPED)')
>>> deprecatedsetup([ped]) >>> deprecatedsetup([ped])
>>> pe = polib.POEntry( >>> pe = polib.POEntry(
... msgid = 'Something (DEPRECATED)', ... msgid = 'Something (DEPRECATED)',
... msgstr= 'something (DEPRECATED)') ... msgstr= 'something (DEPRECATED)')
>>> match(deprecated, pe) >>> match(deprecated, pe)
True True
>>> for e in deprecated(pe): print e >>> for e in deprecated(pe): print(e)
>>> pe = polib.POEntry( >>> pe = polib.POEntry(
... msgid = 'Something (DEPRECATED)', ... msgid = 'Something (DEPRECATED)',
... msgstr= 'something (DETACERPED)') ... msgstr= 'something (DETACERPED)')
>>> match(deprecated, pe) >>> match(deprecated, pe)
True True
>>> for e in deprecated(pe): print e >>> for e in deprecated(pe): print(e)
>>> pe = polib.POEntry( >>> pe = polib.POEntry(
... msgid = 'Something (DEPRECATED)', ... msgid = 'Something (DEPRECATED)',
... msgstr= 'something') ... msgstr= 'something')
>>> match(deprecated, pe) >>> match(deprecated, pe)
True True
>>> for e in deprecated(pe): print e >>> for e in deprecated(pe): print(e)
msgstr inconsistently translated (DEPRECATED) msgstr inconsistently translated (DEPRECATED)
>>> pe = polib.POEntry( >>> pe = polib.POEntry(
... msgid = 'Something (DEPRECATED, foo bar)', ... msgid = 'Something (DEPRECATED, foo bar)',
... msgstr= 'something (DETACERPED, foo bar)') ... msgstr= 'something (DETACERPED, foo bar)')
>>> match(deprecated, pe) >>> match(deprecated, pe)
""" """
if not ('(DEPRECATED)' in pe.msgstr or if not ('(DEPRECATED)' in pe.msgstr or
(deprecatedpe and (deprecatedpe and
deprecatedpe.msgstr in pe.msgstr)): deprecatedpe.msgstr in pe.msgstr)):
yield "msgstr inconsistently translated (DEPRECATED)" yield "msgstr inconsistently translated (DEPRECATED)"
#################### ####################
def warningchecker(msgidpat=None): def warningchecker(msgidpat=None):
return levelchecker('warning', msgidpat) return levelchecker('warning', msgidpat)
@warningchecker() @warningchecker()
def taildoublecolons(pe): def taildoublecolons(pe):
"""Check equality of tail '::'-ness between msgid and msgstr """Check equality of tail '::'-ness between msgid and msgstr
>>> pe = polib.POEntry( >>> pe = polib.POEntry(
... msgid ='ends with ::', ... msgid ='ends with ::',
... msgstr='ends with ::') ... msgstr='ends with ::')
>>> for e in taildoublecolons(pe): print e >>> for e in taildoublecolons(pe): print(e)
>>> pe = polib.POEntry( >>> pe = polib.POEntry(
... msgid ='ends with ::', ... msgid ='ends with ::',
... msgstr='ends without double-colons') ... msgstr='ends without double-colons')
>>> for e in taildoublecolons(pe): print e >>> for e in taildoublecolons(pe): print(e)
tail '::'-ness differs between msgid and msgstr tail '::'-ness differs between msgid and msgstr
>>> pe = polib.POEntry( >>> pe = polib.POEntry(
... msgid ='ends without double-colons', ... msgid ='ends without double-colons',
... msgstr='ends with ::') ... msgstr='ends with ::')
>>> for e in taildoublecolons(pe): print e >>> for e in taildoublecolons(pe): print(e)
tail '::'-ness differs between msgid and msgstr tail '::'-ness differs between msgid and msgstr
""" """
if pe.msgid.endswith('::') != pe.msgstr.endswith('::'): if pe.msgid.endswith('::') != pe.msgstr.endswith('::'):
yield "tail '::'-ness differs between msgid and msgstr" yield "tail '::'-ness differs between msgid and msgstr"
@warningchecker() @warningchecker()
def indentation(pe): def indentation(pe):
"""Check equality of initial indentation between msgid and msgstr """Check equality of initial indentation between msgid and msgstr
This may report unexpected warning, because this doesn't aware This may report unexpected warning, because this doesn't aware
the syntax of rst document and the context of msgstr. the syntax of rst document and the context of msgstr.
>>> pe = polib.POEntry( >>> pe = polib.POEntry(
... msgid =' indented text', ... msgid =' indented text',
... msgstr=' narrowed indentation') ... msgstr=' narrowed indentation')
>>> for e in indentation(pe): print e >>> for e in indentation(pe): print(e)
initial indentation width differs betweeen msgid and msgstr initial indentation width differs betweeen msgid and msgstr
""" """
idindent = len(pe.msgid) - len(pe.msgid.lstrip()) idindent = len(pe.msgid) - len(pe.msgid.lstrip())
strindent = len(pe.msgstr) - len(pe.msgstr.lstrip()) strindent = len(pe.msgstr) - len(pe.msgstr.lstrip())
if idindent != strindent: if idindent != strindent:
yield "initial indentation width differs betweeen msgid and msgstr" yield "initial indentation width differs betweeen msgid and msgstr"
#################### ####################