This is an archive of the discontinued Mercurial Phabricator instance.

remotenames: synchronise remotenames after push also
ClosedPublic

Authored by pulkit on Mar 15 2018, 9:49 AM.

Details

Summary

Earlier we use to pull remotenames information from the server in case of pull
and clone only. This patch adds logic to push also command to pull remotenames
information.

This will help us in keeping the remotenames more upto date where there are a
lot people changing state of branches and bookmarks at the server.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Mar 15 2018, 9:49 AM
pulkit updated this revision to Diff 7104.Mar 19 2018, 4:36 AM
pulkit updated this revision to Diff 7250.Mar 22 2018, 3:35 AM
pulkit updated this revision to Diff 7287.Mar 26 2018, 7:47 AM
indygreg accepted this revision.Apr 11 2018, 1:34 PM
indygreg added a subscriber: indygreg.

I'm not crazy about the implementation. But for an experimental feature, I think it is fine. The bundle2 changes to do this right are definitely scope bloat.

mercurial/exchange.py
491

In a bundle2 world, the news names would ideally be returned by a bundle2 part (this will require 2 extra round trips to the server as implemented). But I think this implementation is fine for an experimental feature.

Also, if the local repo doesn't have names from the remote, we'll never see them. At some point down the long shallow clone road, we'll need to consider what we should be about nodes we know exist remotely but aren't available locally. But this problem can be deferred for a while.

This revision is now accepted and ready to land.Apr 11 2018, 1:34 PM
pulkit updated this revision to Diff 8735.May 18 2018, 10:02 AM

Irrespective of D2873 and D2875, this should be non-controversial and good to go.

pulkit updated this revision to Diff 9314.Jun 26 2018, 5:46 PM
durin42 accepted this revision.Jul 9 2018, 10:25 AM
This revision was automatically updated to reflect the committed changes.