This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2895

py3: use "%d" % int instead of str(int)
ClosedPublic

Authored by pulkit on Mar 19 2018, 3:31 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG1bf555cb680e: py3: use "%d" % int instead of str(int)
Summary

We need to use bytes internally.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Mar 19 2018, 3:31 AM
yuja accepted this revision.Mar 19 2018, 9:34 AM
This revision is now accepted and ready to land.Mar 19 2018, 9:34 AM
Closed by commit rHG1bf555cb680e: py3: use "%d" % int instead of str(int) (authored by pulkit). · Explain WhyMar 19 2018, 9:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (2 lines)

Diff 7100

mercurial/commands.py

notice = _(' (inactive)') notice = _(' (inactive)')
current = (tag == repo.dirstate.branch()) current = (tag == repo.dirstate.branch())
if current: if current:
label = 'branches.current' label = 'branches.current'
fm.startitem() fm.startitem()
fm.write('branch', '%s', tag, label=label) fm.write('branch', '%s', tag, label=label)
rev = ctx.rev() rev = ctx.rev()
padsize = max(31 - len(str(rev)) - encoding.colwidth(tag), 0) padsize = max(31 - len("%d" % rev) - encoding.colwidth(tag), 0)
fmt = ' ' * padsize + ' %d:%s' fmt = ' ' * padsize + ' %d:%s'
fm.condwrite(not ui.quiet, 'rev node', fmt, rev, hexfunc(ctx.node()), fm.condwrite(not ui.quiet, 'rev node', fmt, rev, hexfunc(ctx.node()),
label='log.changeset changeset.%s' % ctx.phasestr()) label='log.changeset changeset.%s' % ctx.phasestr())
fm.context(ctx=ctx) fm.context(ctx=ctx)
fm.data(active=isactive, closed=not isopen, current=current) fm.data(active=isactive, closed=not isopen, current=current)
if not ui.quiet: if not ui.quiet:
fm.plain(notice) fm.plain(notice)
fm.plain('\n') fm.plain('\n')