This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2925

localrepo: move featuresetupfuncs out of localrepository class (API)
ClosedPublic

Authored by indygreg on Mar 21 2018, 8:12 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGecac0006b90e: localrepo: move featuresetupfuncs out of localrepository class (API)
Summary

I want to establish an interface for local repositories.

featuresetupfuncs is a class attribute and is global/shared across all
localrepository instances. Let's move it to a module-level attribute
to clarify it isn't part of the local repository interface.

.. api::

localrepo.localrepository.featuresetupfuncs has been renamed to
localrepo.featuresetupfuncs.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 21 2018, 8:12 PM
indygreg updated this revision to Diff 7240.Mar 22 2018, 12:09 AM
pulkit accepted this revision.Mar 28 2018, 6:04 AM
Closed by commit rHGecac0006b90e: localrepo: move featuresetupfuncs out of localrepository class (API) (authored by indygreg). · Explain WhyMar 28 2018, 6:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7348

hgext/largefiles/__init__.py

reposetup = reposetup.reposetup reposetup = reposetup.reposetup
def featuresetup(ui, supported): def featuresetup(ui, supported):
# don't die on seeing a repo with the largefiles requirement # don't die on seeing a repo with the largefiles requirement
supported |= {'largefiles'} supported |= {'largefiles'}
def uisetup(ui): def uisetup(ui):
localrepo.localrepository.featuresetupfuncs.add(featuresetup) localrepo.featuresetupfuncs.add(featuresetup)
hg.wirepeersetupfuncs.append(proto.wirereposetup) hg.wirepeersetupfuncs.append(proto.wirereposetup)
uisetupmod.uisetup(ui) uisetupmod.uisetup(ui)
cmdtable = lfcommands.cmdtable cmdtable = lfcommands.cmdtable
revsetpredicate = overrides.revsetpredicate revsetpredicate = overrides.revsetpredicate

hgext/lfs/__init__.py

templatekeyword = registrar.templatekeyword() templatekeyword = registrar.templatekeyword()
filesetpredicate = registrar.filesetpredicate() filesetpredicate = registrar.filesetpredicate()
def featuresetup(ui, supported): def featuresetup(ui, supported):
# don't die on seeing a repo with the lfs requirement # don't die on seeing a repo with the lfs requirement
supported |= {'lfs'} supported |= {'lfs'}
def uisetup(ui): def uisetup(ui):
localrepo.localrepository.featuresetupfuncs.add(featuresetup) localrepo.featuresetupfuncs.add(featuresetup)
def reposetup(ui, repo): def reposetup(ui, repo):
# Nothing to do with a remote repo # Nothing to do with a remote repo
if not repo.local(): if not repo.local():
return return
repo.svfs.lfslocalblobstore = blobstore.local(repo) repo.svfs.lfslocalblobstore = blobstore.local(repo)
repo.svfs.lfsremoteblobstore = blobstore.remote(repo) repo.svfs.lfsremoteblobstore = blobstore.remote(repo)

mercurial/localrepo.py

return changegroup.makechangegroup(self._repo, outgoing, '01', source) return changegroup.makechangegroup(self._repo, outgoing, '01', source)
# End of baselegacywirecommands interface. # End of baselegacywirecommands interface.
# Increment the sub-version when the revlog v2 format changes to lock out old # Increment the sub-version when the revlog v2 format changes to lock out old
# clients. # clients.
REVLOGV2_REQUIREMENT = 'exp-revlogv2.0' REVLOGV2_REQUIREMENT = 'exp-revlogv2.0'
# Functions receiving (ui, features) that extensions can register to impact
# the ability to load repositories with custom requirements. Only
# functions defined in loaded extensions are called.
#
# The function receives a set of requirement strings that the repository
# is capable of opening. Functions will typically add elements to the
# set to reflect that the extension knows how to handle that requirements.
featuresetupfuncs = set()
class localrepository(object): class localrepository(object):
# obsolete experimental requirements: # obsolete experimental requirements:
# - manifestv2: An experimental new manifest format that allowed # - manifestv2: An experimental new manifest format that allowed
# for stem compression of long paths. Experiment ended up not # for stem compression of long paths. Experiment ended up not
# being successful (repository sizes went up due to worse delta # being successful (repository sizes went up due to worse delta
# chains), and the code was deleted in 4.6. # chains), and the code was deleted in 4.6.
supportedformats = { supportedformats = {
'exp-sparse', 'exp-sparse',
} }
openerreqs = { openerreqs = {
'revlogv1', 'revlogv1',
'generaldelta', 'generaldelta',
'treemanifest', 'treemanifest',
} }
# a list of (ui, featureset) functions.
# only functions defined in module of enabled extensions are invoked
featuresetupfuncs = set()
# list of prefix for file which can be written without 'wlock' # list of prefix for file which can be written without 'wlock'
# Extensions should extend this list when needed # Extensions should extend this list when needed
_wlockfreeprefix = { _wlockfreeprefix = {
# We migh consider requiring 'wlock' for the next # We migh consider requiring 'wlock' for the next
# two, but pretty much all the existing code assume # two, but pretty much all the existing code assume
# wlock is not needed so we keep them excluded for # wlock is not needed so we keep them excluded for
# now. # now.
'hgrc', 'hgrc',
# This list it to be filled by extension during repo setup # This list it to be filled by extension during repo setup
self._phasedefaults = [] self._phasedefaults = []
try: try:
self.ui.readconfig(self.vfs.join("hgrc"), self.root) self.ui.readconfig(self.vfs.join("hgrc"), self.root)
self._loadextensions() self._loadextensions()
except IOError: except IOError:
pass pass
if self.featuresetupfuncs: if featuresetupfuncs:
self.supported = set(self._basesupported) # use private copy self.supported = set(self._basesupported) # use private copy
extmods = set(m.__name__ for n, m extmods = set(m.__name__ for n, m
in extensions.extensions(self.ui)) in extensions.extensions(self.ui))
for setupfunc in self.featuresetupfuncs: for setupfunc in featuresetupfuncs:
if setupfunc.__module__ in extmods: if setupfunc.__module__ in extmods:
setupfunc(self.ui, self.supported) setupfunc(self.ui, self.supported)
else: else:
self.supported = self._basesupported self.supported = self._basesupported
color.setup(self.ui) color.setup(self.ui)
# Add compression engines. # Add compression engines.
for name in util.compengines: for name in util.compengines:

tests/test-requires.t

> from mercurial import extensions, localrepo > from mercurial import extensions, localrepo
> def featuresetup(ui, supported): > def featuresetup(ui, supported):
> for name, module in extensions.extensions(ui): > for name, module in extensions.extensions(ui):
> if __name__ == module.__name__: > if __name__ == module.__name__:
> # support specific feature locally > # support specific feature locally
> supported |= {'featuresetup-test'} > supported |= {'featuresetup-test'}
> return > return
> def uisetup(ui): > def uisetup(ui):
> localrepo.localrepository.featuresetupfuncs.add(featuresetup) > localrepo.featuresetupfuncs.add(featuresetup)
> EOF > EOF
$ cat > supported/.hg/hgrc <<EOF $ cat > supported/.hg/hgrc <<EOF
> [extensions] > [extensions]
> # enable extension locally > # enable extension locally
> supportlocally = $TESTTMP/supported-locally/supportlocally.py > supportlocally = $TESTTMP/supported-locally/supportlocally.py
> EOF > EOF
$ hg -R supported status $ hg -R supported status