This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2929

thirdparty: don't make zope a namespace package
ClosedPublic

Authored by indygreg on Mar 22 2018, 12:09 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG338367d44d34: thirdparty: don't make zope a namespace package
Summary

There are a gazillion zope.* packages in the wild. So zope/__init__.py
needs to be a namespace package. But in Mercurial, we have 1 zope
package. And even if we had multiple packages, they'd all be in
thirdparty/zope/. So we don't need a namespace package.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 22 2018, 12:09 AM
durin42 accepted this revision.Mar 29 2018, 1:02 PM
This revision is now accepted and ready to land.Mar 29 2018, 1:02 PM
Closed by commit rHG338367d44d34: thirdparty: don't make zope a namespace package (authored by indygreg). · Explain WhyMar 30 2018, 2:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7395

mercurial/thirdparty/zope/__init__.py

# this is a namespace package
try:
import pkg_resources
pkg_resources.declare_namespace(__name__)
except ImportError:
import pkgutil
__path__ = pkgutil.extend_path(__path__, __name__)