This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2964

context: change default changeid from old form '' to '.'
ClosedPublic

Authored by martinvonz on Mar 29 2018, 12:46 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG05c13e5aa9ec: context: change default changeid from old form '' to '.'
Summary

I don't think I've seen repo[''] in the codebase at least in the last
two years.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 29 2018, 12:46 PM
pulkit accepted this revision.Mar 29 2018, 1:50 PM
Closed by commit rHG05c13e5aa9ec: context: change default changeid from old form '' to '.' (authored by martinvonz). · Explain WhyMar 29 2018, 2:04 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Mar 30 2018, 8:15 AM
yuja added inline comments.
mercurial/context.py
65

Nit: one more changeid='' here.

martinvonz added inline comments.Mar 30 2018, 10:48 AM
mercurial/context.py
65

Good catch. I found this one while working on the next series, so it will get fixed then.

Revision Contents
Changeset List

Diff 7364

mercurial/context.py

class basectx(object): class basectx(object):
"""A basectx object represents the common logic for its children: """A basectx object represents the common logic for its children:
changectx: read-only context that is already present in the repo, changectx: read-only context that is already present in the repo,
workingctx: a context that represents the working directory and can workingctx: a context that represents the working directory and can
be committed, be committed,
memctx: a context that represents changes in-memory and can also memctx: a context that represents changes in-memory and can also
be committed.""" be committed."""
def __new__(cls, repo, changeid='', *args, **kwargs): def __new__(cls, repo, changeid='', *args, **kwargs):
yujaUnsubmitted
Not Done

Nit: one more changeid='' here.

yuja: Nit: one more `changeid=''` here.
martinvonzAuthorUnsubmitted
Not Done

Good catch. I found this one while working on the next series, so it will get fixed then.

martinvonz: Good catch. I found this one while working on the next series, so it will get fixed then.
if isinstance(changeid, basectx): if isinstance(changeid, basectx):
return changeid return changeid
o = super(basectx, cls).__new__(cls) o = super(basectx, cls).__new__(cls)
o._repo = repo o._repo = repo
o._rev = nullrev o._rev = nullrev
o._node = nullid o._node = nullid
msg = _("filtered revision '%s' (not in '%s' subset)") msg = _("filtered revision '%s' (not in '%s' subset)")
msg %= (changeid, repo.filtername) msg %= (changeid, repo.filtername)
return error.FilteredRepoLookupError(msg) return error.FilteredRepoLookupError(msg)
class changectx(basectx): class changectx(basectx):
"""A changecontext object makes access to data related to a particular """A changecontext object makes access to data related to a particular
changeset convenient. It represents a read-only context already present in changeset convenient. It represents a read-only context already present in
the repo.""" the repo."""
def __init__(self, repo, changeid=''): def __init__(self, repo, changeid='.'):
"""changeid is a revision number, node, or tag""" """changeid is a revision number, node, or tag"""
# since basectx.__new__ already took care of copying the object, we # since basectx.__new__ already took care of copying the object, we
# don't need to do anything in __init__, so we just exit here # don't need to do anything in __init__, so we just exit here
if isinstance(changeid, basectx): if isinstance(changeid, basectx):
return return
if changeid == '': if changeid == '':