This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3012

scmutil: deprecate revpairnodes()
ClosedPublic

Authored by martinvonz on Apr 1 2018, 3:10 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGd29f6fbd1181: scmutil: deprecate revpairnodes()
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 1 2018, 3:10 AM
yuja added a subscriber: yuja.Apr 1 2018, 6:32 AM

One more revpairnodes() in tests/autodiff.py.

Queued the other patches, thanks.

martinvonz added a comment.Apr 1 2018, 12:32 PM
In D3012#48707, @yuja wrote:

One more revpairnodes() in tests/autodiff.py.
Queued the other patches, thanks.

Oops, I had actually fixed that, but I had the patches out of order in my stack and ended up not sending it. Sent as D3013 now. Thanks for noticing.

pulkit accepted this revision.Apr 1 2018, 12:37 PM
Closed by commit rHGd29f6fbd1181: scmutil: deprecate revpairnodes() (authored by martinvonz). · Explain WhyApr 1 2018, 1:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7503

mercurial/scmutil.py

raise error.Abort(_('empty revision set')) raise error.Abort(_('empty revision set'))
return repo[l.last()] return repo[l.last()]
def _pairspec(revspec): def _pairspec(revspec):
tree = revsetlang.parse(revspec) tree = revsetlang.parse(revspec)
return tree and tree[0] in ('range', 'rangepre', 'rangepost', 'rangeall') return tree and tree[0] in ('range', 'rangepre', 'rangepost', 'rangeall')
def revpairnodes(repo, revs): def revpairnodes(repo, revs):
repo.ui.deprecwarn("revpairnodes is deprecated, please use revpair", "4.6")
ctx1, ctx2 = revpair(repo, revs) ctx1, ctx2 = revpair(repo, revs)
return ctx1.node(), ctx2.node() return ctx1.node(), ctx2.node()
def revpair(repo, revs): def revpair(repo, revs):
if not revs: if not revs:
return repo['.'], repo[None] return repo['.'], repo[None]
l = revrange(repo, revs) l = revrange(repo, revs)