This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3048

bundle: avoid repo.lookup() for converting revnum to nodeid
ClosedPublic

Authored by martinvonz on Apr 3 2018, 6:08 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG0b4692b9646d: bundle: avoid repo.lookup() for converting revnum to nodeid
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Apr 3 2018, 6:08 PM
indygreg accepted this revision.Apr 3 2018, 7:12 PM
This revision is now accepted and ready to land.Apr 3 2018, 7:12 PM
Closed by commit rHG0b4692b9646d: bundle: avoid repo.lookup() for converting revnum to nodeid (authored by martinvonz). · Explain WhyApr 3 2018, 7:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (4 lines)

Diff 7579

mercurial/commands.py

if cgversion not in changegroup.supportedoutgoingversions(repo): if cgversion not in changegroup.supportedoutgoingversions(repo):
raise error.Abort(_("repository does not support bundle version %s") % raise error.Abort(_("repository does not support bundle version %s") %
cgversion) cgversion)
if base: if base:
if dest: if dest:
raise error.Abort(_("--base is incompatible with specifying " raise error.Abort(_("--base is incompatible with specifying "
"a destination")) "a destination"))
common = [repo.lookup(rev) for rev in base] common = [repo[rev].node() for rev in base]
heads = [repo.lookup(r) for r in revs] if revs else None heads = [repo[r].node() for r in revs] if revs else None
outgoing = discovery.outgoing(repo, common, heads) outgoing = discovery.outgoing(repo, common, heads)
else: else:
dest = ui.expandpath(dest or 'default-push', dest or 'default') dest = ui.expandpath(dest or 'default-push', dest or 'default')
dest, branches = hg.parseurl(dest, opts.get('branch')) dest, branches = hg.parseurl(dest, opts.get('branch'))
other = hg.peer(repo, opts, dest) other = hg.peer(repo, opts, dest)
revs, checkout = hg.addbranchrevs(repo, repo, branches, revs) revs, checkout = hg.addbranchrevs(repo, repo, branches, revs)
heads = revs and map(repo.lookup, revs) or revs heads = revs and map(repo.lookup, revs) or revs
outgoing = discovery.findcommonoutgoing(repo, other, outgoing = discovery.findcommonoutgoing(repo, other,