( )⚙ D3053 outgoing: avoid repo.lookup() for converting revnum to nodeid

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3053

outgoing: avoid repo.lookup() for converting revnum to nodeid
ClosedPublic

Authored by martinvonz on Apr 3 2018, 6:08 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG70c52800940b: outgoing: avoid repo.lookup() for converting revnum to nodeid
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 3 2018, 6:08 PM
indygreg accepted this revision.Apr 3 2018, 7:14 PM
This revision is now accepted and ready to land.Apr 3 2018, 7:14 PM
Closed by commit rHG70c52800940b: outgoing: avoid repo.lookup() for converting revnum to nodeid (authored by martinvonz). · Explain WhyApr 3 2018, 7:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hg.py (2 lines)

Diff 7593

mercurial/hg.py

raise error.Abort(_('default repository not configured!'), raise error.Abort(_('default repository not configured!'),
hint=_("see 'hg help config.paths'")) hint=_("see 'hg help config.paths'"))
dest = path.pushloc or path.loc dest = path.pushloc or path.loc
branches = path.branch, opts.get('branch') or [] branches = path.branch, opts.get('branch') or []
ui.status(_('comparing with %s\n') % util.hidepassword(dest)) ui.status(_('comparing with %s\n') % util.hidepassword(dest))
revs, checkout = addbranchrevs(repo, repo, branches, opts.get('rev')) revs, checkout = addbranchrevs(repo, repo, branches, opts.get('rev'))
if revs: if revs:
revs = [repo.lookup(rev) for rev in scmutil.revrange(repo, revs)] revs = [repo[rev].node() for rev in scmutil.revrange(repo, revs)]
other = peer(repo, opts, dest) other = peer(repo, opts, dest)
outgoing = discovery.findcommonoutgoing(repo, other, revs, outgoing = discovery.findcommonoutgoing(repo, other, revs,
force=opts.get('force')) force=opts.get('force'))
o = outgoing.missing o = outgoing.missing
if not o: if not o:
scmutil.nochangesfound(repo.ui, repo, outgoing.excluded) scmutil.nochangesfound(repo.ui, repo, outgoing.excluded)
return o, other return o, other