This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3074

hgweb: inline changeidctx()
ClosedPublic

Authored by martinvonz on Apr 4 2018, 12:41 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG6407507e12b6: hgweb: inline changeidctx()
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 4 2018, 12:41 PM
durin42 accepted this revision.Apr 4 2018, 2:19 PM
This revision is now accepted and ready to land.Apr 4 2018, 2:19 PM
Closed by commit rHG6407507e12b6: hgweb: inline changeidctx() (authored by martinvonz). · Explain WhyApr 4 2018, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/webutil.py (7 lines)

Diff 7630

mercurial/hgweb/webutil.py

} }
return entries return entries
def cleanpath(repo, path): def cleanpath(repo, path):
path = path.lstrip('/') path = path.lstrip('/')
return pathutil.canonpath(repo.root, '', path) return pathutil.canonpath(repo.root, '', path)
def changeidctx(repo, changeid):
return repo[changeid]
def changectx(repo, req): def changectx(repo, req):
changeid = "tip" changeid = "tip"
if 'node' in req.qsparams: if 'node' in req.qsparams:
changeid = req.qsparams['node'] changeid = req.qsparams['node']
ipos = changeid.find(':') ipos = changeid.find(':')
if ipos != -1: if ipos != -1:
changeid = changeid[(ipos + 1):] changeid = changeid[(ipos + 1):]
return changeidctx(repo, changeid) return repo[changeid]
def basechangectx(repo, req): def basechangectx(repo, req):
if 'node' in req.qsparams: if 'node' in req.qsparams:
changeid = req.qsparams['node'] changeid = req.qsparams['node']
ipos = changeid.find(':') ipos = changeid.find(':')
if ipos != -1: if ipos != -1:
changeid = changeid[:ipos] changeid = changeid[:ipos]
return changeidctx(repo, changeid) return repo[changeid]
return None return None
def filectx(repo, req): def filectx(repo, req):
if 'file' not in req.qsparams: if 'file' not in req.qsparams:
raise ErrorResponse(HTTP_NOT_FOUND, 'file not given') raise ErrorResponse(HTTP_NOT_FOUND, 'file not given')
path = cleanpath(repo, req.qsparams['file']) path = cleanpath(repo, req.qsparams['file'])
if 'node' in req.qsparams: if 'node' in req.qsparams: