This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3075

hgweb: use revsymbol() for creating context from changeid
ClosedPublic

Authored by martinvonz on Apr 4 2018, 12:41 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG956260cbc564: hgweb: use revsymbol() for creating context from changeid
Summary

These seem to be for looking up a revision that can come from the
user, so revsymbol() is the right method to call (0194dac7 has more
information about my plans for repo[x]).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 4 2018, 12:41 PM
durin42 accepted this revision.Apr 4 2018, 2:19 PM
This revision is now accepted and ready to land.Apr 4 2018, 2:19 PM
Closed by commit rHG956260cbc564: hgweb: use revsymbol() for creating context from changeid (authored by martinvonz). · Explain WhyApr 4 2018, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/webutil.py (7 lines)

Diff 7631

mercurial/hgweb/webutil.py

context, context,
error, error,
match, match,
mdiff, mdiff,
obsutil, obsutil,
patch, patch,
pathutil, pathutil,
pycompat, pycompat,
scmutil,
templatefilters, templatefilters,
templatekw, templatekw,
ui as uimod, ui as uimod,
util, util,
) )
from ..utils import ( from ..utils import (
stringutil, stringutil,
def changectx(repo, req): def changectx(repo, req):
changeid = "tip" changeid = "tip"
if 'node' in req.qsparams: if 'node' in req.qsparams:
changeid = req.qsparams['node'] changeid = req.qsparams['node']
ipos = changeid.find(':') ipos = changeid.find(':')
if ipos != -1: if ipos != -1:
changeid = changeid[(ipos + 1):] changeid = changeid[(ipos + 1):]
return repo[changeid] return scmutil.revsymbol(repo, changeid)
def basechangectx(repo, req): def basechangectx(repo, req):
if 'node' in req.qsparams: if 'node' in req.qsparams:
changeid = req.qsparams['node'] changeid = req.qsparams['node']
ipos = changeid.find(':') ipos = changeid.find(':')
if ipos != -1: if ipos != -1:
changeid = changeid[:ipos] changeid = changeid[:ipos]
return repo[changeid] return scmutil.revsymbol(repo, changeid)
return None return None
def filectx(repo, req): def filectx(repo, req):
if 'file' not in req.qsparams: if 'file' not in req.qsparams:
raise ErrorResponse(HTTP_NOT_FOUND, 'file not given') raise ErrorResponse(HTTP_NOT_FOUND, 'file not given')
path = cleanpath(repo, req.qsparams['file']) path = cleanpath(repo, req.qsparams['file'])
if 'node' in req.qsparams: if 'node' in req.qsparams:
changeid = req.qsparams['node'] changeid = req.qsparams['node']
elif 'filenode' in req.qsparams: elif 'filenode' in req.qsparams:
changeid = req.qsparams['filenode'] changeid = req.qsparams['filenode']
else: else:
raise ErrorResponse(HTTP_NOT_FOUND, 'node or filenode not given') raise ErrorResponse(HTTP_NOT_FOUND, 'node or filenode not given')
try: try:
fctx = repo[changeid][path] fctx = scmutil.revsymbol(repo, changeid)[path]
except error.RepoError: except error.RepoError:
fctx = repo.filectx(path, fileid=changeid) fctx = repo.filectx(path, fileid=changeid)
return fctx return fctx
def linerange(req): def linerange(req):
linerange = req.qsparams.getall('linerange') linerange = req.qsparams.getall('linerange')
if not linerange: if not linerange: