( )⚙ D3125 py3: convert user value to bytes by b'' prefix

This is an archive of the discontinued Mercurial Phabricator instance.

py3: convert user value to bytes by b'' prefix
ClosedPublic

Authored by pulkit on Apr 5 2018, 8:31 AM.

Details

Summary

This makes test-journal* pass on Python 3.5.

  1. skip-blame beacuse just b'' prefix

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Apr 5 2018, 8:31 AM
yuja requested changes to this revision.Apr 5 2018, 9:45 AM
yuja added a subscriber: yuja.

Unicode issue is handled by posix.py. The problem is mockgetuser()
returns a unicode string.

This revision now requires changes to proceed.Apr 5 2018, 9:45 AM
pulkit added a comment.Apr 5 2018, 3:23 PM
In D3125#50284, @yuja wrote:

Unicode issue is handled by posix.py. The problem is mockgetuser()
returns a unicode string.

Thanks, I overlooked that and was unable to find what can cause trouble so just added an extra fsencode() call.

pulkit edited the summary of this revision. (Show Details)Apr 5 2018, 3:26 PM
pulkit retitled this revision from py3: convert user value to bytes using pycompat.fsencode() to py3: convert user value to bytes by b'' prefix.
pulkit updated this revision to Diff 7751.
This revision was automatically updated to reflect the committed changes.