This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3137

histedit: simplify desthistedit
ClosedPublic

Authored by lothiraldan on Apr 5 2018, 12:23 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGb95992605ef1: histedit: simplify desthistedit
Summary

Instead of sorting the revset and take the first one, take the minimum
revision.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Apr 5 2018, 12:23 PM
Closed by commit rHGb95992605ef1: histedit: simplify desthistedit (authored by lothiraldan). · Explain WhyApr 6 2018, 8:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/destutil.py (6 lines)

Diff 7780

mercurial/destutil.py

default = ui.config('histedit', 'defaultrev') default = ui.config('histedit', 'defaultrev')
if default is None: if default is None:
revs = stack.getstack(repo) revs = stack.getstack(repo)
elif default: elif default:
revs = scmutil.revrange(repo, [default]) revs = scmutil.revrange(repo, [default])
if revs: if revs:
# The revset supplied by the user may not be in ascending order nor # Take the first revision of the revset as the root
# take the first revision. So do this manually. return revs.min()
revs.sort()
return revs.first()
return None return None
def stackbase(ui, repo): def stackbase(ui, repo):
revs = stack.getstack(repo) revs = stack.getstack(repo)
return revs.first() if revs else None return revs.first() if revs else None
def _statusotherbook(ui, repo): def _statusotherbook(ui, repo):