This is an archive of the discontinued Mercurial Phabricator instance.

stack: return a sorted smartrev by default
ClosedPublic

Authored by lothiraldan on Feb 23 2018, 5:36 AM.

Details

Summary

Most stack customers will display a list of revisions, sort it by default.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Feb 23 2018, 5:36 AM
indygreg requested changes to this revision.Feb 23 2018, 9:41 PM
indygreg added a subscriber: indygreg.

Looks good. But only marking as needing changes because I think we may get rid of hg debugstack.

This revision now requires changes to proceed.Feb 23 2018, 9:41 PM
lothiraldan updated this revision to Diff 6215.Feb 28 2018, 6:59 PM
indygreg accepted this revision.Mar 19 2018, 4:02 PM
This revision is now accepted and ready to land.Mar 19 2018, 4:02 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Mar 21 2018, 10:26 AM
yuja added inline comments.
mercurial/stack.py
25

reverse() can be removed as well?

lothiraldan marked an inline comment as done.Apr 5 2018, 11:53 AM
lothiraldan added inline comments.
mercurial/stack.py
25

reverse is removed in the next commit https://phab.mercurial-scm.org/D2400

lothiraldan marked an inline comment as done.Apr 5 2018, 12:17 PM