This is an archive of the discontinued Mercurial Phabricator instance.

histedit: use the new stack definition for histedit
ClosedPublic

Authored by lothiraldan on Feb 23 2018, 5:36 AM.

Details

Summary

Now that we have a common stack definition, use it in the hg histedit command.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Feb 23 2018, 5:36 AM
indygreg requested changes to this revision.Feb 23 2018, 9:40 PM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
mercurial/destutil.py
345–349

This means we can mark the default value for this option as None.

This revision now requires changes to proceed.Feb 23 2018, 9:40 PM
lothiraldan updated this revision to Diff 6214.Feb 28 2018, 6:59 PM
indygreg accepted this revision.Mar 19 2018, 4:00 PM
This revision is now accepted and ready to land.Mar 19 2018, 4:00 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Mar 21 2018, 10:19 AM
yuja added inline comments.
mercurial/destutil.py
356

Can be return revs.min()?

lothiraldan marked an inline comment as done.Apr 5 2018, 12:25 PM
lothiraldan added inline comments.
mercurial/destutil.py
356

It seems so and it's much simpler to read. I have sent a follow-up: https://phab.mercurial-scm.org/D3137