This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6706

stack: remove unnecessary reverse() predicate
ClosedPublic

Authored by av6 on Aug 2 2019, 4:11 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG77c52ce50e6a: stack: remove unnecessary reverse() predicate
Summary

Stack already sorts revisions, so no need to do it twice.

This change was a part of D2400, which didn't land for other reasons. See also
D2399, where this change was suggested.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Aug 2 2019, 4:11 AM
pulkit accepted this revision.Aug 6 2019, 7:27 AM
This revision is now accepted and ready to land.Aug 6 2019, 7:27 AM
av6 added a commit: rHG77c52ce50e6a: stack: remove unnecessary reverse() predicate.Aug 6 2019, 9:02 AM
Closed by commit rHG77c52ce50e6a: stack: remove unnecessary reverse() predicate (authored by av6). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/stack.py (2 lines)

Diff 16138

mercurial/stack.py

not None or the current working directory parent. not None or the current working directory parent.
The stack will always contain all drafts changesets which are ancestors to The stack will always contain all drafts changesets which are ancestors to
the revision and are not merges. the revision and are not merges.
""" """
if rev is None: if rev is None:
rev = '.' rev = '.'
revspec = 'reverse(only(%s) and not public() and not ::merge())' revspec = 'only(%s) and not public() and not ::merge()'
revset = revsetlang.formatspec(revspec, rev) revset = revsetlang.formatspec(revspec, rev)
revisions = scmutil.revrange(repo, [revset]) revisions = scmutil.revrange(repo, [revset])
revisions.sort() revisions.sort()
return revisions return revisions