This is an archive of the discontinued Mercurial Phabricator instance.

revset: drop argument when it's None
ClosedPublic

Authored by av6 on Aug 2 2019, 4:12 AM.

Details

Summary

getstack's definition is getstack(repo, rev=None), so providing None
explicitly is unnecessary. Moreover, when x is not None, it's definitely not a
revision but a part of a parsed tree of revset arguments.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Aug 2 2019, 4:12 AM
pulkit accepted this revision.Aug 6 2019, 7:27 AM
This revision is now accepted and ready to land.Aug 6 2019, 7:27 AM
This revision was automatically updated to reflect the committed changes.