( )⚙ D6707 revset: drop argument when it's None

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6707

revset: drop argument when it's None
ClosedPublic

Authored by av6 on Aug 2 2019, 4:12 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG911e25dc9d8c: revset: drop argument when it's None
Summary

getstack's definition is getstack(repo, rev=None), so providing None
explicitly is unnecessary. Moreover, when x is not None, it's definitely not a
revision but a part of a parsed tree of revset arguments.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Aug 2 2019, 4:12 AM
pulkit accepted this revision.Aug 6 2019, 7:27 AM
This revision is now accepted and ready to land.Aug 6 2019, 7:27 AM
av6 added a commit: rHG911e25dc9d8c: revset: drop argument when it's None.Aug 6 2019, 9:02 AM
Closed by commit rHG911e25dc9d8c: revset: drop argument when it's None (authored by av6). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revset.py (2 lines)

Diff 16139

mercurial/revset.py

return _phase(repo, subset, target) return _phase(repo, subset, target)
@predicate('stack([revs])', safe=True) @predicate('stack([revs])', safe=True)
def stack(repo, subset, x): def stack(repo, subset, x):
"""Experimental revset for the stack of changesets or working directory """Experimental revset for the stack of changesets or working directory
parent. (EXPERIMENTAL) parent. (EXPERIMENTAL)
""" """
if x is None: if x is None:
stacks = stackmod.getstack(repo, x) stacks = stackmod.getstack(repo)
else: else:
stacks = smartset.baseset([]) stacks = smartset.baseset([])
for revision in getset(repo, fullreposet(repo), x): for revision in getset(repo, fullreposet(repo), x):
currentstack = stackmod.getstack(repo, revision) currentstack = stackmod.getstack(repo, revision)
stacks = stacks + currentstack stacks = stacks + currentstack
return subset & stacks return subset & stacks