This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3153

tests: call rawsize() directly
ClosedPublic

Authored by indygreg on Apr 5 2018, 8:51 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGcc4b569975ed: tests: call rawsize() directly
Summary

rawsize() is not reimplemented outside of revlog. I'm not sure why
this code was insisting it call a specific implementation. Changing
it to call rawsize() on the repo.file(f) result seems to work just
fine.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Apr 5 2018, 8:51 PM
quark added a subscriber: quark.Apr 6 2018, 4:01 PM

It was revlog.revlog.size, and got changed to rawsize before committed.

durin42 accepted this revision.Apr 6 2018, 9:00 PM
This revision is now accepted and ready to land.Apr 6 2018, 9:00 PM
Closed by commit rHGcc4b569975ed: tests: call rawsize() directly (authored by indygreg). · Explain WhyApr 6 2018, 9:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-lfs.t (2 lines)

Diff 7767

tests/test-lfs.t

> h.update(rawtext) > h.update(rawtext)
> return h.hexdigest()[:4] > return h.hexdigest()[:4]
> def reposetup(ui, repo): > def reposetup(ui, repo):
> # these 2 files are interesting > # these 2 files are interesting
> for name in ['l', 's']: > for name in ['l', 's']:
> fl = repo.file(name) > fl = repo.file(name)
> if len(fl) == 0: > if len(fl) == 0:
> continue > continue
> sizes = [revlog.revlog.rawsize(fl, i) for i in fl] > sizes = [fl.rawsize(i) for i in fl]
> texts = [fl.revision(i, raw=True) for i in fl] > texts = [fl.revision(i, raw=True) for i in fl]
> flags = [int(fl.flags(i)) for i in fl] > flags = [int(fl.flags(i)) for i in fl]
> hashes = [hash(t) for t in texts] > hashes = [hash(t) for t in texts]
> print(' %s: rawsizes=%r flags=%r hashes=%r' > print(' %s: rawsizes=%r flags=%r hashes=%r'
> % (name, sizes, flags, hashes)) > % (name, sizes, flags, hashes))
> EOF > EOF
$ for i in client client2 server repo3 repo4 repo5 repo6 repo7 repo8 repo9 \ $ for i in client client2 server repo3 repo4 repo5 repo6 repo7 repo8 repo9 \