This is an archive of the discontinued Mercurial Phabricator instance.

Differential D316

largefiles: remove remotestore.batch()
ClosedPublic

Authored by indygreg on Aug 10 2017, 2:47 AM.

Details

Reviewers
quark
Group Reviewers
hg-reviewers
Commits
rHGdcdc17551653: largefiles: remove remotestore.batch()
Summary

This method was added in 9e1616307c4c. AFAICT it didn't do anything at
inception. If it did, there was no test coverage for it because
changing it to raise doesn't fail any tests at that revision.

b6e71f8af5b8 later refactored all remote.batch() calls to
remote.iterbatch(). So if this was somehow used, it isn't called
any more because there are no calls to .batch() remaining in the
repo.

I suspect the original patch author got confused by the distinction
between the peer/remote interface and the largefiles store. The lf
store is a gateway to a peer instance. It exposes additional
lf-specific methods to execute against a peer. However, it is not
a peer and doesn't need to implement batch() because peer itself
does that.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 10 2017, 2:47 AM
quark accepted this revision.Aug 11 2017, 2:27 AM
Closed by commit rHGdcdc17551653: largefiles: remove remotestore.batch() (authored by indygreg). · Explain WhyAug 11 2017, 2:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/largefiles/remotestore.py (5 lines)

Diff 790

hgext/largefiles/remotestore.py

# Copyright 2010-2011 Fog Creek Software # Copyright 2010-2011 Fog Creek Software
# Copyright 2010-2011 Unity Technologies # Copyright 2010-2011 Unity Technologies
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
'''remote largefile store; the base class for wirestore''' '''remote largefile store; the base class for wirestore'''
from __future__ import absolute_import from __future__ import absolute_import
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial import ( from mercurial import (
error, error,
util, util,
wireproto,
) )
from . import ( from . import (
basestore, basestore,
lfutil, lfutil,
localstore, localstore,
) )
_('changeset %s: %s missing\n') _('changeset %s: %s missing\n')
% (cset, filename)) % (cset, filename))
failed = True failed = True
else: else:
raise RuntimeError('verify failed: unexpected response ' raise RuntimeError('verify failed: unexpected response '
'from statlfile (%r)' % stat) 'from statlfile (%r)' % stat)
return failed return failed
def batch(self):
'''Support for remote batching.'''
return wireproto.remotebatch(self)
def _put(self, hash, fd): def _put(self, hash, fd):
'''Put file with the given hash in the remote store.''' '''Put file with the given hash in the remote store.'''
raise NotImplementedError('abstract method') raise NotImplementedError('abstract method')
def _get(self, hash): def _get(self, hash):
'''Get a iterator for content with the given hash.''' '''Get a iterator for content with the given hash.'''
raise NotImplementedError('abstract method') raise NotImplementedError('abstract method')
def _stat(self, hashes): def _stat(self, hashes):
'''Get information about availability of files specified by '''Get information about availability of files specified by
hashes in the remote store. Return dictionary mapping hashes hashes in the remote store. Return dictionary mapping hashes
to return code where 0 means that file is available, other to return code where 0 means that file is available, other
values if not.''' values if not.'''
raise NotImplementedError('abstract method') raise NotImplementedError('abstract method')