( )⚙ D3207 wireproto: make @wireprotocommand version 1 only by default

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3207

wireproto: make @wireprotocommand version 1 only by default
ClosedPublic

Authored by indygreg on Apr 9 2018, 2:58 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG693cb3768943: wireproto: make @wireprotocommand version 1 only by default
Summary

For backwards compatibility reasons. We want extension provided
commands to opt in to version 2 rather than get inherited
automatically. This will facilitate a clean break between the
protocols.

As part of this, we duplicate some commands used in tests so
there are different command handlers per transport.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 9 2018, 2:58 PM
durin42 accepted this revision.Apr 9 2018, 6:29 PM
This revision is now accepted and ready to land.Apr 9 2018, 6:29 PM
Closed by commit rHG693cb3768943: wireproto: make @wireprotocommand version 1 only by default (authored by indygreg). · Explain WhyApr 11 2018, 12:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireproto.py (2 lines)
Mtests/wireprotohelpers.sh (12 lines)

Diff 7986

mercurial/wireproto.py

POLICY_V2_ONLY = 'v2-only' POLICY_V2_ONLY = 'v2-only'
# For version 1 transports. # For version 1 transports.
commands = commanddict() commands = commanddict()
# For version 2 transports. # For version 2 transports.
commandsv2 = commanddict() commandsv2 = commanddict()
def wireprotocommand(name, args='', transportpolicy=POLICY_ALL, def wireprotocommand(name, args='', transportpolicy=POLICY_V1_ONLY,
permission='push'): permission='push'):
"""Decorator to declare a wire protocol command. """Decorator to declare a wire protocol command.
``name`` is the name of the wire protocol command being provided. ``name`` is the name of the wire protocol command being provided.
``args`` defines the named arguments accepted by the command. It is ``args`` defines the named arguments accepted by the command. It is
ideally a dict mapping argument names to their types. For backwards ideally a dict mapping argument names to their types. For backwards
compatibility, it can be a space-delimited list of argument names. For compatibility, it can be a space-delimited list of argument names. For

tests/wireprotohelpers.sh

cat > dummycommands.py << EOF cat > dummycommands.py << EOF
from mercurial import ( from mercurial import (
wireprototypes, wireprototypes,
wireproto, wireproto,
) )
@wireproto.wireprotocommand('customreadonly', permission='pull') @wireproto.wireprotocommand('customreadonly', permission='pull')
def customreadonly(repo, proto): def customreadonlyv1(repo, proto):
return wireprototypes.bytesresponse(b'customreadonly bytes response')
@wireproto.wireprotocommand('customreadonly', permission='pull',
transportpolicy=wireproto.POLICY_V2_ONLY)
def customreadonlyv2(repo, proto):
return wireprototypes.bytesresponse(b'customreadonly bytes response') return wireprototypes.bytesresponse(b'customreadonly bytes response')
@wireproto.wireprotocommand('customreadwrite', permission='push') @wireproto.wireprotocommand('customreadwrite', permission='push')
def customreadwrite(repo, proto): def customreadwrite(repo, proto):
return wireprototypes.bytesresponse(b'customreadwrite bytes response') return wireprototypes.bytesresponse(b'customreadwrite bytes response')
@wireproto.wireprotocommand('customreadwrite', permission='push',
transportpolicy=wireproto.POLICY_V2_ONLY)
def customreadwritev2(repo, proto):
return wireprototypes.bytesresponse(b'customreadwrite bytes response')
EOF EOF
cat >> $HGRCPATH << EOF cat >> $HGRCPATH << EOF
[extensions] [extensions]
drawdag = $TESTDIR/drawdag.py drawdag = $TESTDIR/drawdag.py
EOF EOF
enabledummycommands() { enabledummycommands() {