This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: disallow commands handlers for multiple transport versions
ClosedPublic

Authored by indygreg on Apr 9 2018, 2:58 PM.

Details

Summary

I think it will be more trouble than it is worth to code version 1
and version 2 command handlers to the same interface. It will feel
awkward to shoehorn functionality into e.g. the version 1 protocol
handler interface. This would likely constrain the ability for version
2 to evolve.

Previous commits introduced a clean separation between command handlers
for version 1 and version 2 transports. This commit reinforces that
separation by dropping support for having a single command handler
service both version 1 and version 2 transports.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 9 2018, 2:58 PM
durin42 accepted this revision.Apr 9 2018, 6:29 PM
This revision is now accepted and ready to land.Apr 9 2018, 6:29 PM
This revision was automatically updated to reflect the committed changes.