This is an archive of the discontinued Mercurial Phabricator instance.

tests: glob away fqdn wherever we print it
ClosedPublic

Authored by durin42 on Apr 11 2018, 5:12 PM.

Details

Summary

These localhost instances are actually from a getfqdn call, which
means on some of my test systems it comes out as localhost.localdomain
or
1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa. I'm
tired of this, so let's glob it away.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Apr 11 2018, 5:12 PM

Is this something where a substitution pattern would work (so that it is automatic)? I looked at subbing in $LOCALIP$ instead of having to glob $LOCALIP lines manually, but I didn't because all I could tell was that the glob helped FreeBSD jails in some way that I probably wouldn't be able to test. These seem somewhat related, maybe. (And I just started hitting this too on CentOS 7.4 for some reason, so +1.)

Is this something where a substitution pattern would work (so that it is automatic)? I looked at subbing in $LOCALIP$ instead of having to glob $LOCALIP lines manually, but I didn't because all I could tell was that the glob helped FreeBSD jails in some way that I probably wouldn't be able to test. These seem somewhat related, maybe. (And I just started hitting this too on CentOS 7.4 for some reason, so +1.)

I think this only shows up in --debug server output, which we didn't have until recently.

I tried *super hard* to get this to work using a replacement mechanism, and failed. This was my "the heck with it, I want to be done" solution.

Is this something where a substitution pattern would work (so that it is automatic)? I looked at subbing in $LOCALIP$ instead of having to glob $LOCALIP lines manually, but I didn't because all I could tell was that the glob helped FreeBSD jails in some way that I probably wouldn't be able to test. These seem somewhat related, maybe. (And I just started hitting this too on CentOS 7.4 for some reason, so +1.)

I think this only shows up in --debug server output, which we didn't have until recently.
I tried *super hard* to get this to work using a replacement mechanism, and failed. This was my "the heck with it, I want to be done" solution.

Seems reasonable, there aren't too many here. I'm more interested in switching $LOCALIP, because I keep hitting that.

indygreg accepted this revision.Apr 12 2018, 11:26 AM
indygreg added a subscriber: indygreg.

I think $LOCALIP$ is the proper place for this fix. But it sounds like there were issues implementing that. Perfect is the enemy of done.

This revision is now accepted and ready to land.Apr 12 2018, 11:26 AM
This revision was automatically updated to reflect the committed changes.