( )⚙ D3252 tests: use `f --newer` instead of `stat -c` in test-fix.t

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3252

tests: use `f --newer` instead of `stat -c` in test-fix.t
ClosedPublic

Authored by durin42 on Apr 11 2018, 5:24 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG314f39e5fa86: tests: use `f --newer` instead of `stat -c` in test-fix.t
Summary

Also increase sleep to two seconds so this test will likely pass on FAT32.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Apr 11 2018, 5:24 PM
indygreg accepted this revision.Apr 12 2018, 11:38 AM
This revision is now accepted and ready to land.Apr 12 2018, 11:38 AM
Closed by commit rHG314f39e5fa86: tests: use `f --newer` instead of `stat -c` in test-fix.t (authored by durin42). · Explain WhyApr 12 2018, 11:39 AM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Apr 13 2018, 7:54 AM
yuja added inline comments.
tests/test-fix.t
495–496

Maybe cp -p to not increment a few microseconds?

499

This means mtime(foo.whole) < mtime(foo.whole.orig), but we
need to assert mtime(foo.whole.orig) >= mtime(foo.whole).

Revision Contents
Changeset List

PathPackages
Mtests/test-fix.t (8 lines)

Diff 8018

tests/test-fix.t

write back to the file, so for example the mtime shouldn't change. write back to the file, so for example the mtime shouldn't change.
$ hg init donttouchunfixedfiles $ hg init donttouchunfixedfiles
$ cd donttouchunfixedfiles $ cd donttouchunfixedfiles
$ printf "NO FIX NEEDED\n" > foo.whole $ printf "NO FIX NEEDED\n" > foo.whole
$ hg add $ hg add
adding foo.whole adding foo.whole
$ OLD_MTIME=`stat -c %Y foo.whole` $ cp foo.whole foo.whole.orig
$ sleep 1 # mtime has a resolution of one second. $ sleep 2 # mtime has a resolution of one or two seconds.
yujaUnsubmitted
Not Done

Maybe cp -p to not increment a few microseconds?

yuja: Maybe `cp -p` to not increment a few microseconds?
$ hg fix --working-dir $ hg fix --working-dir
$ NEW_MTIME=`stat -c %Y foo.whole` $ f foo.whole --newer foo.whole.orig
$ test $OLD_MTIME = $NEW_MTIME foo.whole: older than foo.whole.orig
yujaUnsubmitted
Not Done

This means mtime(foo.whole) < mtime(foo.whole.orig), but we
need to assert mtime(foo.whole.orig) >= mtime(foo.whole).

yuja: This means `mtime(foo.whole) < mtime(foo.whole.orig)`, but we need to assert `mtime(foo.whole.
$ cd .. $ cd ..
When a fixer prints to stderr, we assume that it has failed. We should show the When a fixer prints to stderr, we assume that it has failed. We should show the
error messages to the user, and we should not let the failing fixer affect the error messages to the user, and we should not let the failing fixer affect the
file it was fixing (many code formatters might emit error messages on stderr file it was fixing (many code formatters might emit error messages on stderr
and nothing on stdout, which would cause us the clear the file). We show the and nothing on stdout, which would cause us the clear the file). We show the
user which fixer failed and which revision, but we assume that the fixer will user which fixer failed and which revision, but we assume that the fixer will