This is an archive of the discontinued Mercurial Phabricator instance.

setup: Fix installing in a mingw environment

Authored by glandium on Aug 10 2017, 8:52 PM.


Group Reviewers

The addition, in 9a4adc76c88a, of a hack for the MSVC compiler class was
overwriting the original class for the Mingw32CCompiler class, leading to an
error when the HackedMingw32CCompiler is instantiated.

Diff Detail

rHG Mercurial
Lint Skipped
Unit Tests Skipped

Event Timeline

glandium created this revision.Aug 10 2017, 8:52 PM
quark accepted this revision.Aug 10 2017, 9:01 PM
quark added a subscriber: quark.

Looks good to me. Bonus point if you can remove _ so the variable names match the rest of the code.

Sorry, I rebased to stable, and that created a new differential: D329, even though I updated the local tag.

quark added a comment.Aug 10 2017, 9:31 PM

@glandium phabsend verifies the tags with old versions on Phabricator (so it requires obsstore to work properly). After D122, it will be possible to phabsend --amend and phabsend will use the commit message to update corresponding diffs.

quark requested changes to this revision.Aug 10 2017, 9:36 PM

D329 is a replacement. Maybe abandon this diff then.

This revision now requires changes to proceed.Aug 10 2017, 9:36 PM
glandium abandoned this revision.Aug 10 2017, 10:16 PM