This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3290

logexchange: use command executor for wire protocol commands
ClosedPublic

Authored by indygreg on Apr 12 2018, 3:59 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG0e50dda7e9c1: logexchange: use command executor for wire protocol commands
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 12 2018, 3:59 PM
indygreg updated this revision to Diff 8129.Apr 13 2018, 3:14 PM
durin42 accepted this revision.Apr 13 2018, 5:48 PM
This revision is now accepted and ready to land.Apr 13 2018, 5:48 PM
Closed by commit rHG0e50dda7e9c1: logexchange: use command executor for wire protocol commands (authored by indygreg). · Explain WhyApr 13 2018, 6:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/logexchange.py (13 lines)

Diff 8175

mercurial/logexchange.py

def pullremotenames(localrepo, remoterepo): def pullremotenames(localrepo, remoterepo):
""" """
pulls bookmarks and branches information of the remote repo during a pulls bookmarks and branches information of the remote repo during a
pull or clone operation. pull or clone operation.
localrepo is our local repository localrepo is our local repository
remoterepo is the peer instance remoterepo is the peer instance
""" """
remotepath = activepath(localrepo, remoterepo) remotepath = activepath(localrepo, remoterepo)
bookmarks = remoterepo.listkeys('bookmarks')
with remoterepo.commandexecutor() as e:
bookmarks = e.callcommand('listkeys', {
'namespace': 'bookmarks',
}).result()
# on a push, we don't want to keep obsolete heads since # on a push, we don't want to keep obsolete heads since
# they won't show up as heads on the next pull, so we # they won't show up as heads on the next pull, so we
# remove them here otherwise we would require the user # remove them here otherwise we would require the user
# to issue a pull to refresh the storage # to issue a pull to refresh the storage
bmap = {} bmap = {}
repo = localrepo.unfiltered() repo = localrepo.unfiltered()
for branch, nodes in remoterepo.branchmap().iteritems():
with remoterepo.commandexecutor() as e:
branchmap = e.callcommand('branchmap', {}).result()
for branch, nodes in branchmap.iteritems():
bmap[branch] = [] bmap[branch] = []
for node in nodes: for node in nodes:
if node in repo and not repo[node].obsolete(): if node in repo and not repo[node].obsolete():
bmap[branch].append(hex(node)) bmap[branch].append(hex(node))
saveremotenames(localrepo, remotepath, bmap, bookmarks) saveremotenames(localrepo, remotepath, bmap, bookmarks)