This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3332

httppeer: handle error response from client reactor
ClosedPublic

Authored by indygreg on Apr 13 2018, 5:36 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG8cea0d57bf37: httppeer: handle error response from client reactor
Summary

With this in place, we're now seeing useful errors when running
tests with the new wire protocol enabled!

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 13 2018, 5:36 PM
durin42 accepted this revision.Apr 13 2018, 6:06 PM
This revision is now accepted and ready to land.Apr 13 2018, 6:06 PM
Closed by commit rHG8cea0d57bf37: httppeer: handle error response from client reactor (authored by indygreg). · Explain WhyApr 13 2018, 6:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/httppeer.py (8 lines)

Diff 8190

mercurial/httppeer.py

continue continue
else: else:
result.append(meta['data']) result.append(meta['data'])
if meta['eos']: if meta['eos']:
f.set_result(result) f.set_result(result)
del results[request.requestid] del results[request.requestid]
elif action == 'error':
e = error.RepoError(meta['message'])
if f:
f.set_exception(e)
else:
raise e
else: else:
e = error.ProgrammingError('unhandled action: %s' % action) e = error.ProgrammingError('unhandled action: %s' % action)
if f: if f:
f.set_exception(e) f.set_exception(e)
else: else:
raise e raise e