This is an archive of the discontinued Mercurial Phabricator instance.

py3: use stringutil.forcebytestr() instead of str()
ClosedPublic

Authored by pulkit on Apr 13 2018, 4:48 PM.

Details

Summary

We need to convert errors to bytes using stringutil.forcebytestr()

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Apr 13 2018, 4:48 PM
durin42 accepted this revision.Apr 13 2018, 6:11 PM
This revision is now accepted and ready to land.Apr 13 2018, 6:11 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Apr 13 2018, 11:07 PM

FYI, this one could be just bytes(e).