( )⚙ D3329 py3: add b'' prefixes to make values bytes

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3329

py3: add b'' prefixes to make values bytes
ClosedPublic

Authored by pulkit on Apr 13 2018, 4:49 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG2a42ca2679e2: py3: add b'' prefixes to make values bytes
Summary
  1. skip-blame beacuse just b'' prefixes

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Apr 13 2018, 4:49 PM
durin42 accepted this revision.Apr 13 2018, 6:12 PM
This revision is now accepted and ready to land.Apr 13 2018, 6:12 PM
Closed by commit rHG2a42ca2679e2: py3: add b'' prefixes to make values bytes (authored by pulkit). · Explain WhyApr 13 2018, 6:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-clone-cgi.t (2 lines)
Mtests/test-clone.t (8 lines)

Diff 8149

tests/test-clone-cgi.t

$ cat >hgweb.cgi <<HGWEB $ cat >hgweb.cgi <<HGWEB
> # > #
> # An example CGI script to use hgweb, edit as necessary > # An example CGI script to use hgweb, edit as necessary
> import cgitb > import cgitb
> cgitb.enable() > cgitb.enable()
> from mercurial import demandimport; demandimport.enable() > from mercurial import demandimport; demandimport.enable()
> from mercurial.hgweb import hgweb > from mercurial.hgweb import hgweb
> from mercurial.hgweb import wsgicgi > from mercurial.hgweb import wsgicgi
> application = hgweb("test", "Empty test repository") > application = hgweb(b"test", b"Empty test repository")
> wsgicgi.launch(application) > wsgicgi.launch(application)
> HGWEB > HGWEB
$ chmod 755 hgweb.cgi $ chmod 755 hgweb.cgi
try hgweb request try hgweb request
$ . "$TESTDIR/cgienv" $ . "$TESTDIR/cgienv"
$ QUERY_STRING="cmd=changegroup&roots=0000000000000000000000000000000000000000"; export QUERY_STRING $ QUERY_STRING="cmd=changegroup&roots=0000000000000000000000000000000000000000"; export QUERY_STRING

tests/test-clone.t

Issue2267: Error in 1.6 hg.py: TypeError: 'NoneType' object is not Issue2267: Error in 1.6 hg.py: TypeError: 'NoneType' object is not
iterable in addbranchrevs() iterable in addbranchrevs()
$ cat <<EOF > simpleclone.py $ cat <<EOF > simpleclone.py
> from mercurial import ui, hg > from mercurial import ui, hg
> myui = ui.ui.load() > myui = ui.ui.load()
> repo = hg.repository(myui, 'a') > repo = hg.repository(myui, b'a')
> hg.clone(myui, {}, repo, dest="ua") > hg.clone(myui, {}, repo, dest=b"ua")
> EOF > EOF
$ $PYTHON simpleclone.py $ $PYTHON simpleclone.py
updating to branch default updating to branch default
3 files updated, 0 files merged, 0 files removed, 0 files unresolved 3 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ rm -r ua $ rm -r ua
$ cat <<EOF > branchclone.py $ cat <<EOF > branchclone.py
> from mercurial import ui, hg, extensions > from mercurial import ui, hg, extensions
> myui = ui.ui.load() > myui = ui.ui.load()
> extensions.loadall(myui) > extensions.loadall(myui)
> repo = hg.repository(myui, 'a') > repo = hg.repository(myui, b'a')
> hg.clone(myui, {}, repo, dest="ua", branch=["stable",]) > hg.clone(myui, {}, repo, dest=b"ua", branch=[b"stable",])
> EOF > EOF
$ $PYTHON branchclone.py $ $PYTHON branchclone.py
adding changesets adding changesets
adding manifests adding manifests
adding file changes adding file changes
added 14 changesets with 14 changes to 3 files added 14 changesets with 14 changes to 3 files
new changesets acb14030fe0a:0aae7cf88f0d new changesets acb14030fe0a:0aae7cf88f0d