( )⚙ D3360 hook: use stringutil.pprint instead of reinventing it

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3360

hook: use stringutil.pprint instead of reinventing it
ClosedPublic

Authored by durin42 on Apr 14 2018, 12:32 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG483de34f23b1: hook: use stringutil.pprint instead of reinventing it
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Apr 14 2018, 12:32 AM
indygreg accepted this revision.Apr 16 2018, 7:17 PM
This revision is now accepted and ready to land.Apr 16 2018, 7:17 PM
Closed by commit rHG483de34f23b1: hook: use stringutil.pprint instead of reinventing it (authored by durin42). · Explain WhyApr 16 2018, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hook.py (7 lines)

Diff 8354

mercurial/hook.py

encoding, encoding,
error, error,
extensions, extensions,
pycompat, pycompat,
util, util,
) )
from .utils import ( from .utils import (
procutil, procutil,
stringutil,
) )
def _pythonhook(ui, repo, htype, hname, funcname, args, throw): def _pythonhook(ui, repo, htype, hname, funcname, args, throw):
'''call python hook. hook is callable object, looked up as '''call python hook. hook is callable object, looked up as
name in python module. if callable returns "true", hook name in python module. if callable returns "true", hook
fails, else passes. if hook raises exception, treated as fails, else passes. if hook raises exception, treated as
hook failure. exception propagates if throw is "true". hook failure. exception propagates if throw is "true".
env['HG_PENDING'] = repo.root env['HG_PENDING'] = repo.root
env['HG_HOOKTYPE'] = htype env['HG_HOOKTYPE'] = htype
env['HG_HOOKNAME'] = name env['HG_HOOKNAME'] = name
for k, v in args.iteritems(): for k, v in args.iteritems():
if callable(v): if callable(v):
v = v() v = v()
if isinstance(v, dict): if isinstance(v, dict):
# make the dictionary element order stable across Python v = stringutil.pprint(v, bprefix=False)
# implementations
v = ('{' +
', '.join('%r: %r' % i for i in sorted(v.iteritems())) +
'}')
env['HG_' + k.upper()] = v env['HG_' + k.upper()] = v
if repo: if repo:
cwd = repo.root cwd = repo.root
else: else:
cwd = pycompat.getcwd() cwd = pycompat.getcwd()
r = ui.system(cmd, environ=env, cwd=cwd, blockedtag='exthook-%s' % (name,)) r = ui.system(cmd, environ=env, cwd=cwd, blockedtag='exthook-%s' % (name,))