( )⚙ D3361 hook: also use pprint on lists for stable output on py2/3

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3361

hook: also use pprint on lists for stable output on py2/3
ClosedPublic

Authored by durin42 on Apr 14 2018, 12:32 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG63b7415e37a5: hook: also use pprint on lists for stable output on py2/3
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Apr 14 2018, 12:32 AM
indygreg accepted this revision.Apr 16 2018, 7:17 PM
This revision is now accepted and ready to land.Apr 16 2018, 7:17 PM
Closed by commit rHG63b7415e37a5: hook: also use pprint on lists for stable output on py2/3 (authored by durin42). · Explain WhyApr 16 2018, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hook.py (2 lines)

Diff 8238

mercurial/hook.py

if tr and tr.writepending(): if tr and tr.writepending():
env['HG_PENDING'] = repo.root env['HG_PENDING'] = repo.root
env['HG_HOOKTYPE'] = htype env['HG_HOOKTYPE'] = htype
env['HG_HOOKNAME'] = name env['HG_HOOKNAME'] = name
for k, v in args.iteritems(): for k, v in args.iteritems():
if callable(v): if callable(v):
v = v() v = v()
if isinstance(v, dict): if isinstance(v, (dict, list)):
v = stringutil.pprint(v, bprefix=False) v = stringutil.pprint(v, bprefix=False)
env['HG_' + k.upper()] = v env['HG_' + k.upper()] = v
if repo: if repo:
cwd = repo.root cwd = repo.root
else: else:
cwd = pycompat.getcwd() cwd = pycompat.getcwd()
r = ui.system(cmd, environ=env, cwd=cwd, blockedtag='exthook-%s' % (name,)) r = ui.system(cmd, environ=env, cwd=cwd, blockedtag='exthook-%s' % (name,))