This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3414

phabricator: specify some metadata compatibly with arc.
ClosedPublic

Authored by tom.prince on Apr 18 2018, 9:06 PM.

Details

Reviewers
indygreg
durin42
Group Reviewers
hg-reviewers
Commits
rHG6cf5f5b4eb57: phabricator: specify some metadata compatibly with arc
rHG425d55e54f98: phabricator: specify some metadata compatibly with arc
rHGfb95a54ee45c: phabricator: specify some metadata compatibly with arc.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tom.prince created this revision.Apr 18 2018, 9:06 PM
tom.prince added a reviewer: indygreg.Apr 18 2018, 9:06 PM

This is just enough metadata to support Mozilla's autolanding service.

tom.prince updated this revision to Diff 8408.Apr 19 2018, 12:02 AM
durin42 accepted this revision as: durin42.Apr 19 2018, 2:56 PM
durin42 added a subscriber: durin42.

I'm in favor, and would be fine with this change to a contrib script landing during the freeze. If someone else agrees, please land this.

Closed by commit rHGfb95a54ee45c: phabricator: specify some metadata compatibly with arc. (authored by tom.prince). · Explain WhyApr 19 2018, 8:18 PM
This revision was automatically updated to reflect the committed changes.
pulkit added a subscriber: pulkit.Apr 20 2018, 5:02 AM

There is missing """ which is resulting in SyntaxError. @tom.prince can you followup with a fix?

durin42 added a comment.Apr 20 2018, 10:29 AM
In D3414#54497, @pulkit wrote:

There is missing """ which is resulting in SyntaxError. @tom.prince can you followup with a fix?

Belay that @tom.prince, it looks like this patch got mangled at import time due to a bug in 4.6rc0. We've fixed that bug, and will touch up the damage to this patch. Sorry for the noise!

Revision Contents
Changeset List

PathPackages
Mcontrib/phabricator.py (24 lines)

Diff 8416

contrib/phabricator.py

smartset, smartset,
tags, tags,
url as urlmod, url as urlmod,
util, util,
) )
from mercurial.utils import ( from mercurial.utils import (
procutil, procutil,
) )
from mercurial.utils import (
procutil,
stringutil,
)
cmdtable = {} cmdtable = {}
command = registrar.command(cmdtable)
colortable = {
'phabricator.action.created': 'green', 'phabricator.action.created': 'green',
'phabricator.action.skipped': 'magenta', 'phabricator.action.skipped': 'magenta',
'phabricator.action.updated': 'magenta', 'phabricator.action.updated': 'magenta',
'phabricator.desc': '', 'phabricator.desc': '',
'phabricator.drev': 'bold', 'phabricator.drev': 'bold',
'phabricator.node': '', 'phabricator.node': '',
} }
}), }),
} }
callconduit(ctx.repo(), 'differential.setdiffproperty', params) callconduit(ctx.repo(), 'differential.setdiffproperty', params)
def createdifferentialrevision(ctx, revid=None, parentrevid=None, oldnode=None, def createdifferentialrevision(ctx, revid=None, parentrevid=None, oldnode=None,
olddiff=None, actions=None): olddiff=None, actions=None):
"""create or update a Differential Revision """create or update a Differential Revision
If revid is None, create a new Differential Revision, otherwise update params = {
revid. If parentrevid is not None, set it as a dependency. 'diff_id': diff[r'id'],
'name': 'local:commits',
'data': json.dumps({
ctx.hex(): {
'author': stringutil.person(ctx.user()),
'authorEmail': stringutil.email(ctx.user()),
'time': ctx.date()[0],
},
}),
}
callconduit(ctx.repo(), 'differential.setdiffproperty', params)
def createdifferentialrevision(ctx, revid=None, parentrevid=None, oldnode=None,
olddiff=None, actions=None):
"""create or update a Differential Revision
If oldnode is not None, check if the patch content (without commit message If oldnode is not None, check if the patch content (without commit message
and metadata) has changed before creating another diff. and metadata) has changed before creating another diff.
If actions is not None, they will be appended to the transaction. If actions is not None, they will be appended to the transaction.
""" """
repo = ctx.repo() repo = ctx.repo()
if oldnode: if oldnode:
diffopts = mdiff.diffopts(git=True, context=32767) diffopts = mdiff.diffopts(git=True, context=32767)