This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3486

convcmd: make a copy of heads before mutating it
ClosedPublic

Authored by durin42 on May 8 2018, 9:37 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG73ca1c5e65f8: convcmd: make a copy of heads before mutating it
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.May 8 2018, 9:37 AM
indygreg accepted this revision.May 8 2018, 2:20 PM
This revision is now accepted and ready to land.May 8 2018, 2:20 PM
Closed by commit rHG73ca1c5e65f8: convcmd: make a copy of heads before mutating it (authored by durin42). · Explain WhyMay 8 2018, 2:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/convert/convcmd.py (2 lines)

Diff 8561

hgext/convert/convcmd.py

raise error.Abort(_('splicemap file not found or error reading %s:') raise error.Abort(_('splicemap file not found or error reading %s:')
% path) % path)
return m return m
def walktree(self, heads): def walktree(self, heads):
'''Return a mapping that identifies the uncommitted parents of every '''Return a mapping that identifies the uncommitted parents of every
uncommitted changeset.''' uncommitted changeset.'''
visit = heads visit = list(heads)
known = set() known = set()
parents = {} parents = {}
numcommits = self.source.numcommits() numcommits = self.source.numcommits()
while visit: while visit:
n = visit.pop(0) n = visit.pop(0)
if n in known: if n in known:
continue continue
if n in self.map: if n in self.map: