This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3503

lock: pass sysstr to warnings module
ClosedPublic

Authored by durin42 on May 8 2018, 3:27 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG2efefde3af70: lock: pass sysstr to warnings module
Summary

This makes test-lock.py slightly less broken, but it's still pretty
far from passing.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.May 8 2018, 3:27 PM
indygreg accepted this revision.May 8 2018, 4:17 PM
This revision is now accepted and ready to land.May 8 2018, 4:17 PM
Closed by commit rHG2efefde3af70: lock: pass sysstr to warnings module (authored by durin42). · Explain WhyMay 8 2018, 4:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/lock.py (2 lines)

Diff 8571

mercurial/lock.py

def __enter__(self): def __enter__(self):
return self return self
def __exit__(self, exc_type, exc_value, exc_tb): def __exit__(self, exc_type, exc_value, exc_tb):
self.release() self.release()
def __del__(self): def __del__(self):
if self.held: if self.held:
warnings.warn("use lock.release instead of del lock", warnings.warn(r"use lock.release instead of del lock",
category=DeprecationWarning, category=DeprecationWarning,
stacklevel=2) stacklevel=2)
# ensure the lock will be removed # ensure the lock will be removed
# even if recursive locking did occur # even if recursive locking did occur
self.held = 1 self.held = 1
self.release() self.release()