This is an archive of the discontinued Mercurial Phabricator instance.

Differential D353

extensions: don't give AttributeError bytes message on Python 3
ClosedPublic

Authored by durin42 on Aug 11 2017, 3:52 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG0646608368a9: extensions: don't give AttributeError bytes message on Python 3
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Aug 11 2017, 3:52 PM
yuja accepted this revision as: yuja.Aug 12 2017, 6:22 AM
durin42 updated this revision to Diff 946.Aug 15 2017, 4:18 PM
Closed by commit rHG0646608368a9: extensions: don't give AttributeError bytes message on Python 3 (authored by durin42). · Explain WhyAug 15 2017, 11:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/extensions.py (4 lines)

Diff 800

mercurial/extensions.py

origfn = currcls.__dict__[propname].func origfn = currcls.__dict__[propname].func
assert callable(origfn) assert callable(origfn)
def wrap(*args, **kwargs): def wrap(*args, **kwargs):
return wrapper(origfn, *args, **kwargs) return wrapper(origfn, *args, **kwargs)
currcls.__dict__[propname].func = wrap currcls.__dict__[propname].func = wrap
break break
if currcls is object: if currcls is object:
raise AttributeError( raise AttributeError(r"type '%s' has no property '%s'" % (
_("type '%s' has no property '%s'") % (cls, propname)) cls, propname))
def wrapfunction(container, funcname, wrapper): def wrapfunction(container, funcname, wrapper):
'''Wrap the function named funcname in container '''Wrap the function named funcname in container
Replace the funcname member in the given container with the specified Replace the funcname member in the given container with the specified
wrapper. The container is typically a module, class, or instance. wrapper. The container is typically a module, class, or instance.
The wrapper will be called like The wrapper will be called like