This is an archive of the discontinued Mercurial Phabricator instance.

state: don't have a dict like interface for cmdstate class
ClosedPublic

Authored by pulkit on May 17 2018, 8:06 AM.

Details

Summary

This patch changes the cmdstate class to stop having a dict like interface and
delete the nonzero function. After this patch, the save fuction takes a dict
to store the data and read function returns a dict of the data stored.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.May 17 2018, 8:06 AM
martinvonz added inline comments.
mercurial/state.py
59–63

Is this a direct consequence of removing the dict interface or could it be split out into a separate patch?

pulkit added inline comments.May 17 2018, 2:28 PM
mercurial/state.py
59–63

I will split it into a separate patch.

martinvonz accepted this revision.May 21 2018, 11:59 AM
This revision is now accepted and ready to land.May 21 2018, 11:59 AM
This revision was automatically updated to reflect the committed changes.