( )⚙ D363 commitextras: remove the extension from hgext3rd as it is moved to core

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D363

commitextras: remove the extension from hgext3rd as it is moved to core
ClosedPublic

Authored by pulkit on Aug 12 2017, 4:51 PM.
Tags
None
Subscribers
quark

Details

Reviewers
ryanmce
Group Reviewers
Restricted Project
Commits
rFBHGXb45f43caf225: commitextras: remove the extension from hgext3rd as it is moved to core
Summary

This extension is moved to core as an extension in
https://www.mercurial-scm.org/repo/hg/rev/77c0c36654c8.

This patch also removes the test of the extension.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Aug 12 2017, 4:51 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 12 2017, 4:51 PM
ryanmce accepted this revision.Aug 14 2017, 5:28 AM
This revision is now accepted and ready to land.Aug 14 2017, 5:28 AM
quark added a subscriber: quark.Aug 14 2017, 4:54 PM

The changes are not available in https://www.mercurial-scm.org/repo/hg/ yet so we cannot push these right now.

pulkit added a comment.Aug 15 2017, 6:35 AM

They are pushed now to the core repo, so now you can push them :).

quark added a comment.Aug 16 2017, 5:29 PM

Sorry for the late response. Our internal hg repo is still at an old commit that does not the required changes. I'll push the patches once it moves forward.

@ryanmce: Would you mind if I move it manually (since you are the release oncall)?

ryanmce added a comment.Aug 17 2017, 9:18 AM

Sure, feel free. I'm going to be fixing up tests for a while it looks like anyway.

Closed by commit rFBHGXb45f43caf225: commitextras: remove the extension from hgext3rd as it is moved to core (authored by pulkit). · Explain WhyAug 22 2017, 11:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
DMhgext3rd/commitextras.py (41 lines)
DMtests/test-commitextras.t (17 lines)

Diff 825

hgext3rd/commitextras.py

  • This file was deleted.
# commitextras.py
#
# Copyright 2013 Facebook, Inc.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from mercurial.i18n import _
from mercurial import (
commands,
extensions,
registrar,
)
cmdtable = {}
command = registrar.command(cmdtable)
testedwith = 'ships-with-fb-hgext'
def extsetup(ui):
entry = extensions.wrapcommand(commands.table, 'commit', _commit)
options = entry[1]
options.append(('', 'extra', [],
_('set a changeset\'s extra values'), _("KEY=VALUE")))
def _commit(orig, ui, repo, *pats, **opts):
origcommit = repo.commit
try:
def _wrappedcommit(*innerpats, **inneropts):
extras = opts.get('extra')
if extras:
for raw in extras:
k, v = raw.split('=', 1)
inneropts['extra'][k] = v
return origcommit(*innerpats, **inneropts)
# This __dict__ logic is needed because the normal
# extension.wrapfunction doesn't seem to work.
repo.__dict__['commit'] = _wrappedcommit
return orig(ui, repo, *pats, **opts)
finally:
del repo.__dict__['commit']

tests/test-commitextras.t

  • This file was deleted.
$ cat >> $HGRCPATH << EOF
> [extensions]
> commitextras=$TESTDIR/../hgext3rd/commitextras.py
> EOF
Test stuff
$ hg init repo
$ cd repo
$ touch a
$ hg commit -Aqm a
$ echo a > a
$ hg commit -qm a2 --extra oldhash=foo --extra source=bar
$ hg log -r . -T '{extras % "{extra}\n"}'
branch=default
oldhash=foo
source=bar