This is an archive of the discontinued Mercurial Phabricator instance.

retractboundary: add dryrun parameter
Needs RevisionPublic

Authored by khanchi97 on May 30 2018, 6:25 AM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers
Summary

Added the logic to find those csets whose phase will be changed
without --dry-run and return those csets.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

khanchi97 created this revision.May 30 2018, 6:25 AM
khanchi97 edited the summary of this revision. (Show Details)Jun 1 2018, 2:59 AM
khanchi97 updated this revision to Diff 8948.
pulkit added a subscriber: pulkit.Jun 1 2018, 5:32 AM
pulkit added inline comments.
mercurial/phases.py
395

Add documentation about dry-run and the return value.

417

Why are we not using this affected set here to find the changesets whose phase is changed?

430

(Not sure which line I should put this comment on)

Just like D3671, here also, the function should return the correct set of changes whose phase have been changed irrespective of the dryrun value passed.

511

This should better be:

`If dryrun is True, no actions will be performed

returns a set of revs whose phase is changed or should be changed`

khanchi97 added inline comments.Jun 1 2018, 8:50 AM
mercurial/phases.py
395

okay

417

Because I think this affected set is calculated after performing actions, when phases are changed. And calculating affected using new phaseroots. Am I missing something here?

430

yeah, I got it.

511

okay, will do this for 'advanceboundry' too

khanchi97 updated this revision to Diff 8959.Jun 3 2018, 9:51 AM
khanchi97 updated this revision to Diff 8960.Jun 3 2018, 9:55 AM
pulkit added a subscriber: yuja.Jul 11 2018, 5:24 PM
pulkit added inline comments.
mercurial/phases.py
417

I think affected can be used here. Maybe @yuja might know better.

@yuja we want to return a set of revs whose phase is changed by this function. Does affected looks like the correct set to you?

baymax requested changes to this revision.Jan 24 2020, 12:32 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:32 PM