rebase: delete the comment which was not following "do not eat my data"
ClosedPublic

Authored by khanchi97 on Jun 16 2018, 9:47 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
khanchi97 created this revision.Jun 16 2018, 9:47 AM

I'm unsure about this change. On one hand, the comment (which appears to have been added to mpm several years ago) implies that we never should have generated backups in this case. On the other, one of the key rules of a VCS is "don't eat my data." Even though we are aborting the operation, I could see some scenarios where someone would want a backup of the aborted/partially-completed rebase.

@durin42: what do you think?

I'm unsure about this change. On one hand, the comment (which appears to have been added to mpm several years ago) implies that we never should have generated backups in this case. On the other, one of the key rules of a VCS is "don't eat my data." Even though we are aborting the operation, I could see some scenarios where someone would want a backup of the aborted/partially-completed rebase.

@durin42: what do you think?

I think the paranoia is probably better overall? Maybe update the comment?

(I don't feel strongly.)

okay, I think following the key rule of VCS would be better. Shall I update
the comment instead?

khanchi97 updated this revision to Diff 9253.Jun 22 2018, 3:08 AM
khanchi97 retitled this revision from rebase: no need to backup rebased csets while aborting to rebase: delete the comment which was not following "do not eat my data".
This revision was automatically updated to reflect the committed changes.