( )⚙ D3885 histedit: improve help text for --no-backup option

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3885

histedit: improve help text for --no-backup option
ClosedPublic

Authored by khanchi97 on Jul 5 2018, 1:37 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG88e6630dc8d0: histedit: improve help text for --no-backup option
Summary

Improved help text for --no-backup option to clearly
define it's meaning.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

khanchi97 created this revision.Jul 5 2018, 1:37 AM
durin42 accepted this revision.Jul 5 2018, 1:39 AM
This revision is now accepted and ready to land.Jul 5 2018, 1:39 AM
Closed by commit rHG88e6630dc8d0: histedit: improve help text for --no-backup option (authored by khanchi97). · Explain WhyJul 5 2018, 1:43 AM
This revision was automatically updated to reflect the committed changes.
martinvonz added a subscriber: martinvonz.Jul 6 2018, 1:42 PM
martinvonz added inline comments.
hgext/histedit.py
928

To me, the "of files" makes it sounds like it's about .orig files, but I don't think that's what it actually is. Can we make it clearer?

khanchi97 added inline comments.Jul 6 2018, 11:03 PM
hgext/histedit.py
928

How about "do not save backup copies of performed actions"?

martinvonz added inline comments.Jul 7 2018, 2:49 AM
hgext/histedit.py
928

Maybe "do not back up edited commits"? Is that reasonably accurate? I'm not sure what the option actually does. Is it both about the new versions that get stripped on --abort and the old versions that get stripped on completion (if not using obsmarkers)?

khanchi97 added inline comments.Jul 7 2018, 3:26 AM
hgext/histedit.py
928

I'm not sure. I don't know its working in case of old version and new version. Don't have good knowledge of obsmarkers yet. Maybe someone else can suggest who has better understanding of it's working?

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (2 lines)

Diff 9439

hgext/histedit.py

[('', 'commands', '', [('', 'commands', '',
_('read history edits from the specified file'), _('FILE')), _('read history edits from the specified file'), _('FILE')),
('c', 'continue', False, _('continue an edit already in progress')), ('c', 'continue', False, _('continue an edit already in progress')),
('', 'edit-plan', False, _('edit remaining actions list')), ('', 'edit-plan', False, _('edit remaining actions list')),
('k', 'keep', False, ('k', 'keep', False,
_("don't strip old nodes after edit is complete")), _("don't strip old nodes after edit is complete")),
('', 'abort', False, _('abort an edit in progress')), ('', 'abort', False, _('abort an edit in progress')),
('o', 'outgoing', False, _('changesets not found in destination')), ('o', 'outgoing', False, _('changesets not found in destination')),
('', 'no-backup', False, _('no backup')), ('', 'no-backup', False, _('do not save backup copies of files')),
martinvonzUnsubmitted
Not Done

To me, the "of files" makes it sounds like it's about .orig files, but I don't think that's what it actually is. Can we make it clearer?

martinvonz: To me, the "of files" makes it sounds like it's about .orig files, but I don't think that's…
khanchi97AuthorUnsubmitted
Not Done

How about "do not save backup copies of performed actions"?

khanchi97: How about "do not save backup copies of performed actions"?
martinvonzUnsubmitted
Not Done

Maybe "do not back up edited commits"? Is that reasonably accurate? I'm not sure what the option actually does. Is it both about the new versions that get stripped on --abort and the old versions that get stripped on completion (if not using obsmarkers)?

martinvonz: Maybe "do not back up edited commits"? Is that reasonably accurate? I'm not sure what the…
khanchi97AuthorUnsubmitted
Not Done

I'm not sure. I don't know its working in case of old version and new version. Don't have good knowledge of obsmarkers yet. Maybe someone else can suggest who has better understanding of it's working?

khanchi97: I'm not sure. I don't know its working in case of old version and new version. Don't have good…
('f', 'force', False, ('f', 'force', False,
_('force outgoing even for unrelated repositories')), _('force outgoing even for unrelated repositories')),
('r', 'rev', [], _('first revision to be edited'), _('REV'))] + ('r', 'rev', [], _('first revision to be edited'), _('REV'))] +
cmdutil.formatteropts, cmdutil.formatteropts,
_("[OPTIONS] ([ANCESTOR] | --outgoing [URL])")) _("[OPTIONS] ([ANCESTOR] | --outgoing [URL])"))
def histedit(ui, repo, *freeargs, **opts): def histedit(ui, repo, *freeargs, **opts):
"""interactively edit changeset history """interactively edit changeset history