absorb: adapt for moved util.binary()
ClosedPublic

Authored by martinvonz on Jul 10 2018, 5:06 PM.

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGX34427d8660bd: absorb: adapt for moved util.binary()
Summary

It was moved into utils.procutil in 8298e55fc9a4 (util: drop
deprecated forwarding to stringutil (API), 2018-05-10).

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped
martinvonz created this revision.Jul 10 2018, 5:06 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2018, 5:06 PM
quark added a subscriber: quark.Jul 10 2018, 5:53 PM
quark added inline comments.
hgext3rd/absorb/__init__.py
619

f.isbinary() is better as LFS could have a fast path. But I'm fine with this change too.
absorb predates LFS so it didn't get this change.

quark accepted this revision.Jul 10 2018, 5:53 PM
This revision is now accepted and ready to land.Jul 10 2018, 5:53 PM
This revision was automatically updated to reflect the committed changes.