( )⚙ D399 filemerge: eliminate most uses of tempfiles

This is an archive of the discontinued Mercurial Phabricator instance.

filemerge: eliminate most uses of tempfiles
ClosedPublic

Authored by phillco on Aug 15 2017, 1:28 AM.

Details

Summary

Emphasize that they're unused so we can more easily remove them later.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

phillco created this revision.Aug 15 2017, 1:28 AM

Small typo in the commit message: s/remobe/remove

phillco edited the summary of this revision. (Show Details)Aug 16 2017, 2:22 PM

Fixed, thanks @lothiraldan :)

phillco edited the summary of this revision. (Show Details)Aug 23 2017, 3:38 PM
phillco updated this revision to Diff 1222.
phillco updated this revision to Diff 1304.Aug 25 2017, 5:01 PM
phillco updated this revision to Diff 1454.Aug 30 2017, 5:12 PM
phillco updated this revision to Diff 1479.Aug 31 2017, 2:00 PM
phillco updated this revision to Diff 1486.Aug 31 2017, 2:29 PM

Seems like you missed two places. Let me know if should fix them in flight

mercurial/filemerge.py
438

why not change here too?

484

and "b, c, back" seem unused here

phillco added a comment.EditedAug 31 2017, 3:52 PM

Feel free to, otherwise I can. Thanks.

phillco edited the summary of this revision. (Show Details)Aug 31 2017, 3:52 PM
In D399#9522, @phillco wrote:

Feel free to, otherwise I can. Thanks.

Done.

phillco edited the summary of this revision. (Show Details)Aug 31 2017, 4:15 PM
phillco updated this revision to Diff 1508.
This revision was automatically updated to reflect the committed changes.
singhsrb edited the summary of this revision. (Show Details)Sep 5 2017, 8:38 PM
singhsrb updated this revision to Diff 1625.